Skip to content

Conversation

@gares
Copy link
Member

@gares gares commented Jul 1, 2025

The vernac classifier did thread around attributes for but was not passing them to custom classifiers (indeed attributes were added after custom classifiers).

Thanks to this a plugin can define a command that opens a proof depending on an attribute, like #[program] or #[refine].

This PR unblocks LPCIC/coq-elpi#831 and HB 2.0

overlay

@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 1, 2025
@gares gares added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares gares force-pushed the vernac-class-atts branch from 014e02e to c86ba0f Compare July 1, 2025 09:38
@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Jul 1, 2025
@gares gares added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares gares force-pushed the vernac-class-atts branch from c86ba0f to e153c50 Compare July 1, 2025 10:14
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares gares added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares gares marked this pull request as ready for review July 1, 2025 10:15
@gares gares requested review from a team as code owners July 1, 2025 10:15
@gares
Copy link
Member Author

gares commented Jul 1, 2025

Now it looks to simple that I wonder if it could target 9.1

@SkySkimmer
Copy link
Contributor

It looks like elpi needs an overlay which is kinda annoying to get in 9.1 but still somewhat possible if done quick I guess.
You will need to provide a 9.1-compatible elpi commit with the overlay.

@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares
Copy link
Member Author

gares commented Jul 1, 2025

It will land shortly.

BTW, I do have a recurrent problem with

        if ! git config get --local commit.template; then
          git config set --local commit.template "$template_file"
        fi

apparently my git version (2.43) does not have these commands

@gares gares added request: full CI Use this label when you want your next push to trigger a full CI. kind: internal API, ML documentation... labels Jul 1, 2025
@gares gares added this to the 9.1+rc1 milestone Jul 1, 2025
gares added a commit to LPCIC/coq-elpi that referenced this pull request Jul 1, 2025
gares added a commit to LPCIC/coq-elpi that referenced this pull request Jul 1, 2025
@SkySkimmer
Copy link
Contributor

BTW, I do have a recurrent problem with

speak on zulip, this isn't the right place

@gares gares force-pushed the vernac-class-atts branch from 5f0676f to 8843c90 Compare July 1, 2025 14:03
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares gares added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares gares force-pushed the vernac-class-atts branch from 8843c90 to 1e9263a Compare July 1, 2025 20:27
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares gares requested a review from a team as a code owner July 1, 2025 20:56
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jul 1, 2025
gares added a commit to gares/metarocq that referenced this pull request Jul 1, 2025
@gares gares force-pushed the vernac-class-atts branch from ec4b4d8 to 8873e51 Compare July 1, 2025 21:13
@gares gares added the request: full CI Use this label when you want your next push to trigger a full CI. label Jul 1, 2025
@gares
Copy link
Member Author

gares commented Jul 2, 2025

@coqbot run full ci

@coqbot-app coqbot-app bot removed request: full CI Use this label when you want your next push to trigger a full CI. needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Jul 2, 2025
@gares
Copy link
Member Author

gares commented Jul 2, 2025

Looks good to me.

@SkySkimmer SkySkimmer self-assigned this Jul 2, 2025
@SkySkimmer
Copy link
Contributor

@coqbot merge now

@gares I let you make the backport PR

@coqbot-app coqbot-app bot merged commit c7cebc9 into rocq-prover:master Jul 2, 2025
6 of 8 checks passed
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Jul 2, 2025

@SkySkimmer: Please take care of the following overlays:

  • 20839-gares-vernac-class-atts.sh

SkySkimmer added a commit to LPCIC/coq-elpi that referenced this pull request Jul 2, 2025
@gares
Copy link
Member Author

gares commented Jul 2, 2025

I'll do it tomorrow

ppedrot added a commit to MetaRocq/metarocq that referenced this pull request Jul 2, 2025
gares added a commit to gares/coq that referenced this pull request Jul 3, 2025
gares added a commit to gares/coq that referenced this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: internal API, ML documentation...

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants