-
Notifications
You must be signed in to change notification settings - Fork 701
[classifier] visibility on attributes #20839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Now it looks to simple that I wonder if it could target 9.1 |
|
It looks like elpi needs an overlay which is kinda annoying to get in 9.1 but still somewhat possible if done quick I guess. |
|
It will land shortly. BTW, I do have a recurrent problem with apparently my git version (2.43) does not have these commands |
speak on zulip, this isn't the right place |
|
@coqbot run full ci |
|
Looks good to me. |
|
@SkySkimmer: Please take care of the following overlays:
|
|
I'll do it tomorrow |
Adapt to rocq-prover/rocq#20839 (classifier sees ~atts)
The vernac classifier did thread around attributes for but was not passing them to custom classifiers (indeed attributes were added after custom classifiers).
Thanks to this a plugin can define a command that opens a proof depending on an attribute, like #[program] or #[refine].
This PR unblocks LPCIC/coq-elpi#831 and HB 2.0
overlay