Search: don't search local defs (unless Unset Search Blacklist Locals) #20349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqbot-app
bot
added
the
needs: full CI
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
search-filter-local
branch
from
3387406 to
22251e8
Compare
coqbot-app
bot
removed
request: full CI
SkySkimmer
added
the
request: full CI
SkySkimmer
force-pushed
the
search-filter-local
branch
from
22251e8 to
0b112db
Compare
coqbot-app
bot
removed
the
request: full CI
ppedrot
approved these changes
Mar 16, 2025
Member
|
Letting a little bit of time for others to chime in just in case, but this looks ready to me. |
3 tasks
Contributor
|
Nice! That's a very good quality of life change! Thank you @SkySkimmer |
| .. flag:: Search Blacklist Locals | ||
|
|
||
| By default :cmd:`Search` excludes lemmas declared with :attr:`local` from its results | ||
| (except for those from the current module or its parents). |
Contributor
There was a problem hiding this comment.
Is it children instead of parents?
Contributor
Author
There was a problem hiding this comment.
It's parents. ie
Module M.
Local Definition foo := ...
Module N.
Search ...M.foo is not excluded because M is parent of the current module M.N.
Member
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.