-
Notifications
You must be signed in to change notification settings - Fork 709
remove NArith.Ndigits, NArith.Ndist, and Strings.ByteVector #18936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove NArith.Ndigits, NArith.Ndist, and Strings.ByteVector #18936
Conversation
Alizter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's been a while since I've reviewed. What was the policy on stdlib deprecations? Is a single version enough? I seem to recall complaints in the past, but that might have been Coq related rather than the stdlib.
|
IIUC the closest thing to a policy is https://inria.hal.science/tel-02451322v1/document 3.6.3.1 saying "features must be deprecated in one major version before they can be removed in the next", without any distinction between stdlib or otherwise. In cep 86 I argue that the duration of deprecation is less important than whether there is an actionable porting plan. For stdlib changes, the worst case of copy-pasting the file removed from Coq does not seem too bad (well, I guess the worst worst case would be Inductive |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
doc/changelog/11-standard-library/18936-remove-ByteVector-Ndist-Ndigits.rst
Show resolved
Hide resolved
Note that this is now in the refman: https://coq.inria.fr/doc/V8.19.0/refman/using/libraries/writing.html @andres-erbsen please list the overlays in the top message If overlays can be merged before the branch https://github.com/coq/coq/wiki/Release-Schedule-for-Coq-8.20 this seems good for 8.20. |
Co-authored-by: Pierre Roux <[email protected]>
remove unneeded Ndigits dependency (adapt to rocq-prover/rocq#18936)
|
🔴 CI failures at commit 573d388 without any failure in the test-suite ✔️ Corresponding jobs for the base commit 7b9f69f succeeded ❔ Ask me to try to extract minimal test cases that can be added to the test-suite 🏃
|
|
@coqbot run full ci |
|
@coqbot merge now |
Backwards-compatible overlays: