Skip to content

Conversation

@andres-erbsen
Copy link
Contributor

@andres-erbsen andres-erbsen commented Apr 15, 2024

@andres-erbsen andres-erbsen added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 15, 2024
@andres-erbsen andres-erbsen requested review from a team as code owners April 15, 2024 18:23
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 15, 2024
@andres-erbsen andres-erbsen added this to the 8.20+rc1 milestone Apr 15, 2024
@andres-erbsen andres-erbsen added the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 15, 2024
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Apr 15, 2024
Copy link
Contributor

@Alizter Alizter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's been a while since I've reviewed. What was the policy on stdlib deprecations? Is a single version enough? I seem to recall complaints in the past, but that might have been Coq related rather than the stdlib.

@Alizter Alizter self-assigned this Apr 15, 2024
@andres-erbsen
Copy link
Contributor Author

andres-erbsen commented Apr 15, 2024

IIUC the closest thing to a policy is https://inria.hal.science/tel-02451322v1/document 3.6.3.1 saying "features must be deprecated in one major version before they can be removed in the next", without any distinction between stdlib or otherwise.

In cep 86 I argue that the duration of deprecation is less important than whether there is an actionable porting plan. For stdlib changes, the worst case of copy-pasting the file removed from Coq does not seem too bad (well, I guess the worst worst case would be Inductive natinf being somehow used in an interface between two non-CI projects for which Coq is the only common dependency, but in this specific case option nat would be a good standin and I don't think this is likely enough to warrant an exceptionally long deprecation regardless).

@coqbot-app

This comment was marked as outdated.

1 similar comment
@coqbot-app

This comment was marked as resolved.

@proux01
Copy link
Contributor

proux01 commented Apr 16, 2024

IIUC the closest thing to a policy is https://inria.hal.science/tel-02451322v1/document 3.6.3.1 saying "features must be deprecated in one major version before they can be removed in the next", without any distinction between stdlib or otherwise.

Note that this is now in the refman: https://coq.inria.fr/doc/V8.19.0/refman/using/libraries/writing.html

@andres-erbsen please list the overlays in the top message

If overlays can be merged before the branch https://github.com/coq/coq/wiki/Release-Schedule-for-Coq-8.20 this seems good for 8.20.

@proux01 proux01 added kind: cleanup Code removal, deprecation, refactorings, etc. zARCHIVED: standard library Previously standard library (do not use anymore, now its own repo). labels Apr 16, 2024
@Alizter Alizter added the needs: overlay This is breaking external developments we track in CI. label Apr 16, 2024
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Apr 16, 2024
proux01 added a commit to rocq-community/corn that referenced this pull request Apr 17, 2024
@andres-erbsen andres-erbsen mentioned this pull request Apr 17, 2024
1 task
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Apr 18, 2024

🔴 CI failures at commit 573d388 without any failure in the test-suite

✔️ Corresponding jobs for the base commit 7b9f69f succeeded

❔ Ask me to try to extract minimal test cases that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following targets: ci-iris, ci-perennial
  • You can also pass me a specific list of targets to minimize as arguments.

@andres-erbsen
Copy link
Contributor Author

@coqbot run full ci

@coqbot-app coqbot-app bot removed the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Apr 19, 2024
@andres-erbsen andres-erbsen removed the needs: overlay This is breaking external developments we track in CI. label Apr 20, 2024
@Alizter
Copy link
Contributor

Alizter commented Apr 20, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit d9f7f94 into rocq-prover:master Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind: cleanup Code removal, deprecation, refactorings, etc. zARCHIVED: standard library Previously standard library (do not use anymore, now its own repo).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants