APIs for elpi stuff #18820
Merged
APIs for elpi stuff #18820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coqbot-app
bot
added
the
needs: full CI
SkySkimmer
reviewed
Mar 19, 2024
pretyping/structures.ml
Outdated
|
|
||
| let projection_number env cst = | ||
| let s = find_from_projection cst in | ||
| CList.index (Option.equal (Environ.QConstant.equal env)) (Some cst) (List.map (fun x -> x.proj_body) s.projections) - 1 |
Contributor
There was a problem hiding this comment.
Suggested change
| CList.index (Option.equal (Environ.QConstant.equal env)) (Some cst) (List.map (fun x -> x.proj_body) s.projections) - 1 | |
| CList.index0 (Option.equal (Environ.QConstant.equal env)) (Some cst) | |
| (List.map (fun x -> x.proj_body) s.projections) |
SkySkimmer
reviewed
Mar 19, 2024
SkySkimmer
reviewed
Mar 19, 2024
Tragicus
force-pushed
the
utils
branch
2 times, most recently
from
3e938da to
2a500ca
Compare
CohenCyril
reviewed
Mar 20, 2024
pretyping/structures.mli
Outdated
Comment on lines
57
to
58
| (** [projection_number env p] returns the position of the projection p in | ||
| the structure it corresponds to. *) |
Contributor
There was a problem hiding this comment.
It should not be necessary to write it down, but in this context I would add that we count from 0.
SkySkimmer
approved these changes
May 23, 2024
SkySkimmer
added
kind: internal
Contributor
|
@coqbot merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few utility functions in
engine/evd.ml(a few accessors) andpretyping/structures.ml(a way to obtain the position of a projection in a structure and a printer for canonical solutions).Fixes / closes #????[ ] Added changelog.