Skip to content

Update CI for latest templates and test more modern Coq/Rocq versions. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lysxia merged 1 commit into from
May 14, 2025
Merged

Update CI for latest templates and test more modern Coq/Rocq versions. #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/docker-action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,17 +16,19 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
coq_version:
- 'dev'
- '8.19'
- '8.18'
image:
- 'coqorg/coq:8.20'
- 'coqorg/coq:8.19'
- 'coqorg/coq:8.18'
- 'rocq/rocq-prover:dev'
- 'rocq/rocq-prover:9.0'
Copy link
Contributor

@SkySkimmer SkySkimmer May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is using image more recommended than coq_version?

Copy link
Member Author

@Zimmi48 Zimmi48 May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not specifically recommended when manually writing a GitHub workflow file. But this one is auto-generated from the Rocq-community templates, which are programmed in a poorly expressive templating language (Mustache), and we want them to support the option of specifying an image (e.g., for MathComp-based projects).

fail-fast: false
steps:
- uses: actions/checkout@v4
- uses: coq-community/docker-coq-action@v1
with:
opam_file: 'coq-math-classes.opam'
coq_version: ${{ matrix.coq_version }}
custom_image: ${{ matrix.image }}
before_install: |
startGroup "Setup and print opam config"
opam repo -a --set-default add coq-extra-dev https://coq.inria.fr/opam/extra-dev
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ notations.
- Bas Spitters ([**@spitters**](https://github.com/spitters))
- Xia Li-yao ([**@Lysxia**](https://github.com/Lysxia))
- License: [MIT License](LICENSE)
- Compatible Coq versions: Coq 8.18 or later (use releases for other Coq versions)
- Compatible Coq versions: Coq/Rocq 8.18 or later (use releases for other Coq/Rocq versions)
- Additional dependencies:
- [BigNums](https://github.com/coq/bignums)
- Coq namespace: `MathClasses`
Expand Down
2 changes: 1 addition & 1 deletion coq-math-classes.opam
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ build: [
]
install: [make "install"]
depends: [
"coq" {(>= "8.18" & < "8.20~") | (= "dev")}
"coq" {(>= "8.18" & < "9.1~") | (= "dev")}
"coq-bignums"
]

Expand Down
10 changes: 7 additions & 3 deletions meta.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,15 @@ license:
identifier: MIT

supported_coq_versions:
text: Coq 8.18 or later (use releases for other Coq versions)
opam: '{(>= "8.18" & < "8.20~") | (= "dev")}'
text: Coq/Rocq 8.18 or later (use releases for other Coq/Rocq versions)
opam: '{(>= "8.18" & < "9.1~") | (= "dev")}'

tested_coq_opam_versions:
tested_rocq_opam_versions:
- version: dev
- version: "9.0"

tested_coq_opam_versions:
- version: "8.20"
- version: "8.19"
- version: "8.18"

Expand Down
Loading