Change from camel/mixed case to snake_case#275
Conversation
virtuald
force-pushed
the
snake-case
branch
6 times, most recently
from
7b1db2d to
cc6d3c6
Compare
|
This is ready for other people to review and take a look at. Please point out any weird transforms that may have occurred that don't make any sense, or other potential improvements. ... don't about reviewing the snake case tooling, I'm going to extract that out and put it in a separate repo or something since it's a single-use thing. |
virtuald
force-pushed
the
snake-case
branch
2 times, most recently
from
459f8d4 to
1d111d3
Compare
virtuald
force-pushed
the
snake-case
branch
3 times, most recently
from
f4b8a6d to
468d534
Compare
virtuald
force-pushed
the
snake-case
branch
2 times, most recently
from
9b965c3 to
ac0f89a
Compare
There was a problem hiding this comment.
First pass review, doesn't include examples / snippets
Overall pretty good, looks much more pythonic! Most of my comments were about questionable renames in tests (command1 -> command_1, etc) I started marking those once per file where I saw it rather than every instance
There are also a couple of rpy C++ files that renamed things that aren't "techincally" necessary if they are getting wrapped anyway.
Overall, I'd classify pretty most of this as nitpicks that I wouldn't want blocking the PR
pjreiniger
left a comment
pjreiniger
left a comment
There was a problem hiding this comment.
Quick pass of the examples. Much less weird naming, but caught a couple
- build-system.requires: semiwrap~=0.6.0
virtuald
force-pushed
the
snake-case
branch
3 times, most recently
from
48de0f5 to
27b7425
Compare
This updates semiwrap to the latest version in preparation for the camel_case change. This version allows you to specify name changes and known words that get passed to the header2dat step of the build, which required some changes to the bazel setup. This should be basically a no-op at the moment, but makes it easier to copybara things over once robotpy/mostrobotpy#275 lands.
|
|
3 participants
This process was entirely AI-driven, using GPT 5.5 and the superpowers plugin. It's still running at the moment, but I figured I'd post it so that progress can be seen. It'll take awhile to review.
As part of the process, it did create some scripting to help out with automating the snake case conversion, so anyone reviewing this should consider looking there first.