Skip to content

Finalize removal of liblog4cxx dependency#38

Merged
bchretien merged 5 commits intoroboptim:masterfrom
bchretien:feat/log4cxx-removal
Jun 29, 2018
Merged

Finalize removal of liblog4cxx dependency#38
bchretien merged 5 commits intoroboptim:masterfrom
bchretien:feat/log4cxx-removal

Conversation

@bchretien
Copy link
Copy Markdown
Member

This follows the work done in roboptim/roboptim-core#120.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 78.876% when pulling 8b77850 on bchretien:feat/log4cxx-removal into 2e04f69 on roboptim:master.

2 similar comments
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 78.876% when pulling 8b77850 on bchretien:feat/log4cxx-removal into 2e04f69 on roboptim:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 78.876% when pulling 8b77850 on bchretien:feat/log4cxx-removal into 2e04f69 on roboptim:master.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 21, 2017

Codecov Report

Merging #38 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #38   +/-   ##
=======================================
  Coverage   74.87%   74.87%           
=======================================
  Files          10       10           
  Lines         398      398           
  Branches       49       49           
=======================================
  Hits          298      298           
  Misses         63       63           
  Partials       37       37
Impacted Files Coverage Δ
src/tnlp.hxx 66.19% <ø> (ø) ⬆️
src/tnlp.hh 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e04f69...4466b72. Read the comment docs.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 21, 2017

Coverage Status

Coverage remained the same at 78.876% when pulling fdc20ea on bchretien:feat/log4cxx-removal into 2e04f69 on roboptim:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 21, 2017

Coverage Status

Coverage remained the same at 78.876% when pulling 4466b72 on bchretien:feat/log4cxx-removal into 2e04f69 on roboptim:master.

@florent-lamiraux
Copy link
Copy Markdown
Member

Is it possible to merge this pull request in order to be able to merge PR#40 in roboptim-trajectory?

@bchretien
Copy link
Copy Markdown
Member Author

@florent-lamiraux I wanted to solve the AppVeyor issue back then but never found the time, I guess the Windows build will fail until I find the motivation. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants