Expose /healthz and /readiness endpoints even if API_KEY is not set#2077
Merged
PawelPeczek-Roboflow merged 4 commits intomainfrom Mar 6, 2026
Merged
Expose /healthz and /readiness endpoints even if API_KEY is not set#2077PawelPeczek-Roboflow merged 4 commits intomainfrom
PawelPeczek-Roboflow merged 4 commits intomainfrom
Conversation
Move API_KEY check inside the PRELOAD_MODELS branch so dedicated deployments can use /healthz and /readiness endpoints for liveness and readiness probes.
|
|
ecarrara
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
Collaborator
|
need to make style and I think we decided to refactor abit to clean up / split the log for preloading and separating from DD/serverless flags for attaching the health/readiness endpoints |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move
API_KEYcheck inside thePRELOAD_MODELSbranch so it no longer gates the entire startup/preloading block. This allows dedicated deployments to start up and serve/healthzand/readinessendpoints for liveness and readiness probes even whenAPI_KEYis not set.Type of Change
Testing
Test details: Deploy a dedicated deployment and verify the pod transitions through startup and readiness probes correctly. ✅
Checklist