fix: handle expired Redis lock release gracefully#2060
Merged
PawelPeczek-Roboflow merged 4 commits intomainfrom Mar 6, 2026
Merged
Conversation
When a redis lock's TTL expires before the code inside the lock finishes executing, calling release() throws "cannot release a lock that's no longer owned".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
dkosowski87
approved these changes
Mar 4, 2026
PawelPeczek-Roboflow
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves dg-319
When a redis lock's TTL expires before the code inside the lock finishes executing, calling release() throws "cannot release a lock that's no longer owned".
What does this PR do?
we want to avoid showing this error in the frontend.
Related Issue(s):
Type of Change
Testing
Test details:
Checklist
Additional Context
Note
Low Risk
Small, localized change to lock cleanup behavior; main risk is potentially masking unexpected premature lock expiry (now surfaced only via a warning log).
Overview
BaseCache.locknow catchesredis.exceptions.LockNotOwnedErrorwhen releasing a lock and logs a warning instead of raising, preventing failures/noisy errors when the lock TTL expires before the protected work completes.Written by Cursor Bugbot for commit 1557dad. This will update automatically on new commits. Configure here.