Skip to content

Update rules docs: pseudo elements, feature queries#901

Merged
robinweser merged 2 commits into
robinweser:masterfrom
pepelsbey:docs-rules
Apr 26, 2022
Merged

Update rules docs: pseudo elements, feature queries#901
robinweser merged 2 commits into
robinweser:masterfrom
pepelsbey:docs-rules

Conversation

@pepelsbey

Copy link
Copy Markdown
Contributor

Description

I’ve been reading the docs and discovered a few places that could be improved. This PR is focused on basics/rules.mdx, but I have a few more improvements in other parts. Please let me know if I should use other PRs for them or combine everything in one place.

Here’s the following:

  • ::before is a pseudo element, not pseudo class
  • It’s preferable to use double colons to differentiate elements from classes (according to spec)
  • It’s worth mentioning that pseudo classes/elements could be combined in a single string, not just nested
  • @supports is a part of Feature queries, not Support queries

Checklist

Quality Assurance

  • The code was formatted using Prettier (pnpm run format)
  • The code has no linting errors (pnpm run lint)
  • All tests are passing (pnpm run test)

Changes

  • Tests have been added/updated
  • Documentation has been added/updated

@vercel

vercel Bot commented Apr 25, 2022

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/A59h31VCsP3EP88B8oPNPb2PAPWf
✅ Preview: https://fela-git-fork-pepelsbey-docs-rules-robinweser.vercel.app

@robinweser robinweser left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements, thank you!

@robinweser robinweser merged commit b89f498 into robinweser:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants