Update rules docs: pseudo elements, feature queries#901
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/robinweser/fela/A59h31VCsP3EP88B8oPNPb2PAPWf |
robinweser
approved these changes
Apr 26, 2022
robinweser
left a comment
Owner
There was a problem hiding this comment.
Nice improvements, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I’ve been reading the docs and discovered a few places that could be improved. This PR is focused on basics/rules.mdx, but I have a few more improvements in other parts. Please let me know if I should use other PRs for them or combine everything in one place.
Here’s the following:
::beforeis a pseudo element, not pseudo class@supportsis a part of Feature queries, not Support queriesChecklist
Quality Assurance
pnpm run format)pnpm run lint)pnpm run test)Changes