Skip to content

add missing ts-typing to jest-react-fela and fela-plugin-fallback-value#873

Merged
robinweser merged 2 commits into
robinweser:masterfrom
jwillem:patch-1
Mar 25, 2021
Merged

add missing ts-typing to jest-react-fela and fela-plugin-fallback-value#873
robinweser merged 2 commits into
robinweser:masterfrom
jwillem:patch-1

Conversation

@jwillem

@jwillem jwillem commented Mar 23, 2021

Copy link
Copy Markdown
Contributor

Description

Hi,
as I was updating to a new fela-version and wanted to remove our type overwrite of jest-react-fela, I've found the following bug: index.d.ts wasn't added to the files array of jest-react-fela.

What I've missed yet, would be a check over all packages, whether index.d.ts is existent in their files-arrays. done

Packages

List all packages that have been changed.

  • jest-react-fela
  • fela-plugin-fallback-value

Versioning

Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@vercel

vercel Bot commented Mar 23, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/6CQbsNKAAnmjhUJi5qtbeDveJrxk
✅ Preview: https://fela-git-fork-jwillem-patch-1-robinweser.vercel.app

@jwillem

jwillem commented Mar 23, 2021

Copy link
Copy Markdown
Contributor Author

With a quick command I also found that,fela-plugin-fallback-value needs an update:
for package in $(ls packages/); do find packages/$package/index.d.ts && echo $package && jq '.files' packages/$package/package.json; done

packages/fela/index.d.ts
fela
[
  "LICENSE",
  "README.md",
  "index.d.ts",
  "lib/**",
  "es/**",
  "umd/**"
]
find: ‘packages/fela-beautifier/index.d.ts’: No such file or directory
find: ‘packages/fela-bindings/index.d.ts’: No such file or directory
find: ‘packages/fela-codemods/index.d.ts’: No such file or directory
find: ‘packages/fela-dom/index.d.ts’: No such file or directory
find: ‘packages/fela-enforce-longhands/index.d.ts’: No such file or directory
find: ‘packages/fela-enzyme/index.d.ts’: No such file or directory
find: ‘packages/fela-identifier/index.d.ts’: No such file or directory
find: ‘packages/fela-integration/index.d.ts’: No such file or directory
find: ‘packages/fela-layout-debugger/index.d.ts’: No such file or directory
find: ‘packages/fela-logger/index.d.ts’: No such file or directory
find: ‘packages/fela-monolithic/index.d.ts’: No such file or directory
find: ‘packages/fela-native/index.d.ts’: No such file or directory
find: ‘packages/fela-perf/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-bidi/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-custom-property/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-embedded/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-expand-shorthand/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-extend/index.d.ts’: No such file or directory
packages/fela-plugin-fallback-value/index.d.ts
**fela-plugin-fallback-value**
[
  "LICENSE",
  "README.md",
  "lib/**",
  "es/**"
]
find: ‘packages/fela-plugin-friendly-pseudo-class/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-fullscreen-prefixer/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-important/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-isolation/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-kebab-case/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-logger/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-multiple-selectors/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-named-keys/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-native-media-query/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-placeholder-prefixer/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-prefixer/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-pseudo-prefixer/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-responsive-value/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-rtl/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-simulate/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-theme-value/index.d.ts’: No such file or directory
packages/fela-plugin-typescript/index.d.ts
fela-plugin-typescript
[
  "LICENSE",
  "README.md",
  "index.d.ts",
  "lib/**",
  "es/**"
]
find: ‘packages/fela-plugin-unit/index.d.ts’: No such file or directory
find: ‘packages/fela-plugin-validator/index.d.ts’: No such file or directory
find: ‘packages/fela-preset-dev/index.d.ts’: No such file or directory
find: ‘packages/fela-preset-web/index.d.ts’: No such file or directory
find: ‘packages/fela-sort-classnames/index.d.ts’: No such file or directory
find: ‘packages/fela-sort-media-query-mobile-first/index.d.ts’: No such file or directory
find: ‘packages/fela-statistics/index.d.ts’: No such file or directory
find: ‘packages/fela-tools/index.d.ts’: No such file or directory
find: ‘packages/fela-utils/index.d.ts’: No such file or directory
packages/inferno-fela/index.d.ts
inferno-fela
[
  "LICENSE",
  "README.md",
  "index.d.ts",
  "lib/**",
  "es/**"
]
find: ‘packages/jest-fela-bindings/index.d.ts’: No such file or directory
find: ‘packages/jest-inferno-fela/index.d.ts’: No such file or directory
find: ‘packages/jest-preact-fela/index.d.ts’: No such file or directory
packages/jest-react-fela/index.d.ts
**jest-react-fela**
[
  "LICENSE",
  "README.md",
  "lib/**",
  "es/**"
]
packages/preact-fela/index.d.ts
preact-fela
[
  "LICENSE",
  "README.md",
  "index.d.ts",
  "lib/**",
  "es/**"
]
packages/react-fela/index.d.ts
react-fela
[
  "LICENSE",
  "README.md",
  "index.d.ts",
  "lib/**",
  "es/**",
  "umd/**"
]
find: ‘packages/reason-fela/index.d.ts’: No such file or directory```

@jwillem jwillem changed the title add missing ts-typing to package add missing ts-typing to jest-react-fela and fela-plugin-fallback-value Mar 23, 2021
@robinweser robinweser merged commit 9898b15 into robinweser:master Mar 25, 2021
@jwillem jwillem deleted the patch-1 branch March 26, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants