Skip to content

[react-fela] Fix useFela hook types to support composition#846

Merged
robinweser merged 1 commit into
robinweser:masterfrom
feedbax:fix-react-fela-types
Jan 19, 2021
Merged

[react-fela] Fix useFela hook types to support composition#846
robinweser merged 1 commit into
robinweser:masterfrom
feedbax:fix-react-fela-types

Conversation

@hedwiggggg

Copy link
Copy Markdown
Contributor

Description

#845

Packages

List all packages that have been changed.

  • react-fela

Versioning

Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@vercel

vercel Bot commented Jan 6, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/prj1o8vzo
✅ Preview: https://fela-git-fork-feedbax-fix-react-fela-types.robinweser.vercel.app

@hedwiggggg hedwiggggg changed the title Fix useFela hook types to support composition [react-fela] Fix useFela hook types to support composition Jan 6, 2021
@robinweser robinweser merged commit 7ccd60b into robinweser:master Jan 19, 2021
@robinweser

Copy link
Copy Markdown
Owner

Amazing, thank you :)

@hedwiggggg hedwiggggg deleted the fix-react-fela-types branch January 19, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants