Skip to content

Fix #3938 Android build issue happening when integrating @rnmapbox/maps with RN 0.81.0#3942

Merged
mfazekas merged 1 commit intornmapbox:mainfrom
whiteHatCip:defects/cannot-build-android-codegen-conflict
Aug 26, 2025
Merged

Fix #3938 Android build issue happening when integrating @rnmapbox/maps with RN 0.81.0#3942
mfazekas merged 1 commit intornmapbox:mainfrom
whiteHatCip:defects/cannot-build-android-codegen-conflict

Conversation

@whiteHatCip
Copy link
Copy Markdown
Contributor

@whiteHatCip whiteHatCip commented Aug 26, 2025

Description

Fixes #3938
Fixes #3936
The changes in this PR only pertain the issue and they are the bare minimum needed to fix the bug

Checklist

  • I've read CONTRIBUTING.md
  • I updated the doc/other generated code with running yarn generate in the root folder
  • I have tested the new feature on /example app.
    • In V11 mode/ios
    • In New Architecture mode/ios
    • In V11 mode/android
    • In New Architecture mode/android
  • I added/updated a sample - if a new feature was implemented (/example)

Android Changes

Spec update:

  • Renamed create(...) → createAnimator(...) in the TypeScript spec to prevent clashes with the base TurboModule::create method in C++/JSI.
  • Regenerated code to reflect the new method name.

Android modules:

  • Updated RNMBXChangeLineOffsetsShapeAnimatorModule.kt and RNMBXMovePointShapeAnimatorModule.kt to implement the new createAnimator(...) signatures generated by codegen.
  • Removed obsolete override fun create(...) which no longer exists in the spec.
  • Aligned parameter types (Double, ReadableArray, Promise) with the generated spec.
    JS API:
  • Calls now go through createAnimator(...)

Motivation

Prevents C++ build failure (-Woverloaded-virtual) caused by naming conflict with TurboModule::create.

…eate` functions defined in Codegen descriptors to `generate` to avoid conflicts with TurboModule's create method
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 26, 2025 00:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 26, 2025 00:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 26, 2025 00:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 26, 2025 00:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 26, 2025 00:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 26, 2025 00:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip temporarily deployed to CI with Mapbox Tokens August 26, 2025 00:06 — with GitHub Actions Inactive
@whiteHatCip whiteHatCip changed the title Fix #3938 Android build issue Fix #3938 Android build issue happening when integrating @rnmapbox/maps with RN 0.81.0 Aug 26, 2025
@mfazekas
Copy link
Copy Markdown
Contributor

@naftalibeder FYI

@mfazekas mfazekas merged commit d1c5ae5 into rnmapbox:main Aug 26, 2025
11 checks passed
@whiteHatCip whiteHatCip deleted the defects/cannot-build-android-codegen-conflict branch August 26, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Not building in Android & iOS For React Native 81.0 in new arch. [Bug]: "hides overloaded virtual function" error while building

2 participants