Skip to content

Check If max_episode_length is None is NPO #2193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Check If max_episode_length is None is NPO #2193

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2ebb26
added check for max_episode_length
ManavR123 Dec 4, 2020
b6808d5
added test
ManavR123 Dec 4, 2020
396f3d6
moved if statement and changed double quotes to single quotes
ManavR123 Dec 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/garage/tf/algos/npo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ def __init__(self,
self.policy = policy
self._scope = scope
self.max_episode_length = env_spec.max_episode_length
if self.max_episode_length == None:
Copy link
Member

@ryanjulian ryanjulian Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please place this validation above the long list of property initializations (i.e. first lines of this method), and put a newline after the if statement

raise ValueError("max_episode_length must not be None")
Copy link
Member

@ryanjulian ryanjulian Dec 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use single quotes in this repo. we have an automated tool called pre-commit which will check your PR for small issues like this and tell you how to fix them (or you can check the CI results below, which will also tell you what to fix).

See the guide here: https://garage.readthedocs.io/en/latest/user/preparing_a_pr.html and https://garage.readthedocs.io/en/latest/user/git_workflow.html#passing-the-pre-commit-hooks

self._env_spec = env_spec
self._baseline = baseline
self._discount = discount
Expand Down
16 changes: 16 additions & 0 deletions tests/garage/tf/algos/test_npo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,22 @@ def test_npo_with_invalid_no_entropy_configuration(self):
entropy_method='no_entropy',
policy_ent_coeff=0.02,
)

@pytest.mark.mujoco
def test_npo_with_invalid_max_episode_length(self):
"""Test NPO with invalid max_episode_length."""
with pytest.raises(ValueError):
env = normalize(
GymEnv('InvertedDoublePendulum-v2', max_episode_length=None))
NPO(
env_spec=env.spec,
policy=self.policy,
baseline=self.baseline,
sampler=self.sampler,
discount=0.99,
gae_lambda=0.98,
policy_ent_coeff=0.0
)

def teardown_method(self):
self.env.close()
Expand Down