Skip to content

Conversation

@Arya-1-HR
Copy link
Contributor

@Arya-1-HR Arya-1-HR commented Dec 11, 2025

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository.
  • I made sure to follow the project's coding style.
  • I've documented every RZ_API function and struct this PR changes.
  • I've added tests that prove my changes are effective (required for changes to RZ_API).
  • I've updated the Rizin book with the relevant information (if needed).
  • I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.

Detailed description

The existing axt command lists the xefs to the function

This PR introduces a new command axtl with verbose variant , like having 2-3 lines of assembly above and below the seek offset and xrefs to the seek function and also function signature which you seek into
...

Test plan
Screenshot 2025-12-12 at 2 14 40 AM

...

Closing issues

closes #5196

...

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 56.81818% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.67%. Comparing base (f32b7cd) to head (4225034).
⚠️ Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
librz/core/cmd/cmd_analysis.c 55.81% 12 Missing and 7 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
librz/core/cmd_descs/cmd_descs.c 50.62% <100.00%> (ø)
librz/core/cmd/cmd_analysis.c 51.32% <55.81%> (+0.01%) ⬆️

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32b7cd...4225034. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Arya-1-HR Arya-1-HR marked this pull request as ready for review December 12, 2025 05:37
@Arya-1-HR
Copy link
Contributor Author

Tests will be added once the review is done and the reviewers are satisfied with the outcome

Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. Also don't forget about fixing the leaks

@Arya-1-HR Arya-1-HR marked this pull request as draft December 15, 2025 04:25
@Arya-1-HR Arya-1-HR marked this pull request as ready for review December 16, 2025 18:28
Copy link
Member

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaks are unrelated.

@notxvilka
Copy link
Contributor

Also rebase

@Arya-1-HR Arya-1-HR requested a review from notxvilka December 17, 2025 19:49
@notxvilka notxvilka merged commit b07369a into rizinorg:dev Dec 17, 2025
46 of 47 checks passed
@Arya-1-HR Arya-1-HR deleted the new-axtl branch December 18, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve axt output - longer command, maybe axtl?

4 participants