Compact mode #5535
Open
Compact mode #5535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasu-baran
requested review from
Rot127,
kazarmy,
ret2libc,
thestr4ng3r and
wargio
as code owners
notxvilka
requested changes
Nov 18, 2025
| if (var->storage.type == RZ_ANALYSIS_VAR_STORAGE_REG && var->storage.reg) { | ||
| // Check if it's in an argument register (common ones) | ||
| const char *reg = var->storage.reg; | ||
| if (reg && (!strcmp(reg, "rdi") || !strcmp(reg, "rsi") || !strcmp(reg, "rdx") || !strcmp(reg, "rcx") || !strcmp(reg, "r8") || !strcmp(reg, "r9") || !strcmp(reg, "edi") || !strcmp(reg, "esi") || !strcmp(reg, "edx") || !strcmp(reg, "ecx") || !strcmp(reg, "r8d") || !strcmp(reg, "r9d") || |
Contributor
There was a problem hiding this comment.
Definitely a wrong way to approach this.
Author
There was a problem hiding this comment.
will work with different approach
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
RZ_APIfunction and struct this PR changes.RZ_API).Detailed description
Combining type information from debug info parameters with register location from variable and re-assign for each parameter
Test plan
...
Closing issues
#5255