Merged
Conversation
kyleconroy
commented
Mar 19, 2025
Comment on lines
+18
to
+20
| // Metadata is used to store additional information about the message for | ||
| // processing by the client or server. It is never sent across the wire. | ||
| Metadata map[string]string |
Contributor
Author
There was a problem hiding this comment.
I'm not super happy with this field, but we need a place to put metadata that isn't sent across the wire. Seemed like an okay place to put it for now
Contributor
Author
|
Since the SSE transport has different behavior for clients and servers, we're going to need to redesign the client / server implementations, but that can come later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5