Conversation
timsifive
force-pushed
the
remove_mr
branch
from
66a536d to
0d4568b
Compare
Collaborator
pdonahue-ventana
left a comment
pdonahue-ventana
left a comment
There was a problem hiding this comment.
The debug_register_printers.h deletion seems to be unrelated. Is that intentional?
These were first introduced in #728. Hopefully I got everything.
timsifive
force-pushed
the
remove_mr
branch
from
0d4568b to
1aab674
Compare
Contributor
Author
Good catch. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were first introduced in #728.
Hopefully I got everything.