-
Notifications
You must be signed in to change notification settings - Fork 367
workflow: Run checkpatch against diff with riscv #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e21553 to
dbf7bd3
Compare
Collaborator
Author
|
This turns out not to be easy. Leaving this for now. |
Instead of arbitrarily picking 20 changes. Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7 Signed-off-by: Tim Newsome <[email protected]>
JanMatCodasip
previously approved these changes
Apr 12, 2023
Collaborator
JanMatCodasip
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improvement looks all right :)
Co-authored-by: Jan Matyas <[email protected]> Signed-off-by: Tim Newsome <[email protected]>
JanMatCodasip
approved these changes
Apr 13, 2023
fanghuaqi
pushed a commit
to riscv-mcu/riscv-openocd
that referenced
this pull request
Jan 25, 2024
* workflow: Run checkpatch against pull request only Instead of arbitrarily picking 20 changes. Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7 Signed-off-by: Tim Newsome <[email protected]> * Display FETCH_HEAD in the log Co-authored-by: Jan Matyas <[email protected]> Signed-off-by: Tim Newsome <[email protected]> --------- Signed-off-by: Tim Newsome <[email protected]> Co-authored-by: Jan Matyas <[email protected]>
fanghuaqi
added a commit
to riscv-mcu/riscv-openocd
that referenced
this pull request
Jan 25, 2024
* workflow: Run checkpatch against diff with riscv (riscv-collab#822) * workflow: Run checkpatch against pull request only Instead of arbitrarily picking 20 changes. Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7 Signed-off-by: Tim Newsome <[email protected]> * Display FETCH_HEAD in the log Co-authored-by: Jan Matyas <[email protected]> Signed-off-by: Tim Newsome <[email protected]> --------- Signed-off-by: Tim Newsome <[email protected]> Co-authored-by: Jan Matyas <[email protected]> * workflow: Use ubuntu-20.04 to build snapshot Ubuntu 18.04 is deprecated by github. Change-Id: Id0e700a99f74b482b0c735be0a12f81fe65b7ca3 Signed-off-by: Tim Newsome <[email protected]> * workflow: Fix linux build by disable werror compile Change-Id: I25c365a2992e1e3747888baf307b0120aaf615dc Signed-off-by: Huaqi Fang <[email protected]> * workflow: fix snapshot build by disable werror compile Change-Id: I2996707b9ffff7a3dbd491e3e37bfd7b891b2c3a Signed-off-by: Huaqi Fang <[email protected]> ci: use checkout v3 Change-Id: Ie3ddaf9f054cf3806586e99e220720ad9d61b047 Signed-off-by: Huaqi Fang <[email protected]> * contrib: add ftd2xx into cross build steps Change-Id: I23b2498d651d2ec1d8bda04c684c3f69724126b0 Signed-off-by: Huaqi Fang <[email protected]> * workflow: add ftd2xx download step for snapshot build Change-Id: If56e0580c766415ccb946c033cec4b9216730ceb Signed-off-by: Huaqi Fang <[email protected]> * contrib: update cross-build.sh * Update cross-build.sh * Update cross-build.sh --------- Signed-off-by: Tim Newsome <[email protected]> Signed-off-by: Huaqi Fang <[email protected]> Co-authored-by: Tim Newsome <[email protected]> Co-authored-by: Jan Matyas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of arbitrarily picking 20 changes.
Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7