Skip to content

Conversation

@timsifive
Copy link
Collaborator

Instead of arbitrarily picking 20 changes.

Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7

@timsifive timsifive force-pushed the checkpatch branch 2 times, most recently from 4e21553 to dbf7bd3 Compare March 22, 2023 16:35
@timsifive
Copy link
Collaborator Author

This turns out not to be easy. Leaving this for now.

Instead of arbitrarily picking 20 changes.

Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7
Signed-off-by: Tim Newsome <[email protected]>
@timsifive timsifive marked this pull request as ready for review April 7, 2023 17:36
@timsifive timsifive requested a review from JanMatCodasip April 7, 2023 17:36
JanMatCodasip
JanMatCodasip previously approved these changes Apr 12, 2023
Copy link
Collaborator

@JanMatCodasip JanMatCodasip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This improvement looks all right :)

Co-authored-by: Jan Matyas <[email protected]>
Signed-off-by: Tim Newsome <[email protected]>
@timsifive timsifive merged commit 4d27429 into riscv Apr 13, 2023
@timsifive timsifive deleted the checkpatch branch April 13, 2023 15:39
fanghuaqi pushed a commit to riscv-mcu/riscv-openocd that referenced this pull request Jan 25, 2024
* workflow: Run checkpatch against pull request only

Instead of arbitrarily picking 20 changes.

Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7
Signed-off-by: Tim Newsome <[email protected]>

* Display FETCH_HEAD in the log

Co-authored-by: Jan Matyas <[email protected]>
Signed-off-by: Tim Newsome <[email protected]>

---------

Signed-off-by: Tim Newsome <[email protected]>
Co-authored-by: Jan Matyas <[email protected]>
fanghuaqi added a commit to riscv-mcu/riscv-openocd that referenced this pull request Jan 25, 2024
* workflow: Run checkpatch against diff with riscv (riscv-collab#822)

* workflow: Run checkpatch against pull request only

Instead of arbitrarily picking 20 changes.

Change-Id: I5ec488aa4faa0b06056aa91d0432cda1674967b7
Signed-off-by: Tim Newsome <[email protected]>

* Display FETCH_HEAD in the log

Co-authored-by: Jan Matyas <[email protected]>
Signed-off-by: Tim Newsome <[email protected]>

---------

Signed-off-by: Tim Newsome <[email protected]>
Co-authored-by: Jan Matyas <[email protected]>

* workflow: Use ubuntu-20.04 to build snapshot

Ubuntu 18.04 is deprecated by github.

Change-Id: Id0e700a99f74b482b0c735be0a12f81fe65b7ca3
Signed-off-by: Tim Newsome <[email protected]>

* workflow: Fix linux build by disable werror compile

Change-Id: I25c365a2992e1e3747888baf307b0120aaf615dc
Signed-off-by: Huaqi Fang <[email protected]>

* workflow: fix snapshot build by disable werror compile

Change-Id: I2996707b9ffff7a3dbd491e3e37bfd7b891b2c3a
Signed-off-by: Huaqi Fang <[email protected]>

ci: use checkout v3

Change-Id: Ie3ddaf9f054cf3806586e99e220720ad9d61b047
Signed-off-by: Huaqi Fang <[email protected]>

* contrib: add ftd2xx into cross build steps

Change-Id: I23b2498d651d2ec1d8bda04c684c3f69724126b0
Signed-off-by: Huaqi Fang <[email protected]>

* workflow: add ftd2xx download step for snapshot build

Change-Id: If56e0580c766415ccb946c033cec4b9216730ceb
Signed-off-by: Huaqi Fang <[email protected]>

* contrib: update cross-build.sh

* Update cross-build.sh

* Update cross-build.sh

---------

Signed-off-by: Tim Newsome <[email protected]>
Signed-off-by: Huaqi Fang <[email protected]>
Co-authored-by: Tim Newsome <[email protected]>
Co-authored-by: Jan Matyas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants