Cherry-pick changes from main to release 2.1 branch for 2.1.1 release
#610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nategraf
commented
Jun 4, 2025
nategraf
commented
- WEB3-448: Add Hoodi deployment to deployment.toml (WEB3-448: Add Hoodi deployment to deployment.toml #586)
- WEB3-455: Deploy set verifier on base sepolia (WEB3-455: Deploy set verifier on base sepolia #603)
- WEB3-462: Migrate CI to cluster (WEB3-462: Migrate CI to cluster #608)
- update control ids and deployment information
- update Foundry in CI to 1.2.2
- WEB3-458: Update the Steel beacon block commit validation to always revert on invalid timestamps (WEB3-458: Update the Steel beacon block commit validation to always revert on invalid timestamps #605)
- WEB3-456: Deploy SetVerifier 0.7 and add Etherscan verification script (WEB3-456: Deploy SetVerifier 0.7 and add Etherscan verification script #604)
Contributor
Author
|
Note that this PR should be added to the release branch with the rebase action to preserve commit history |
nategraf
force-pushed
the
victor/release-2.1-cherry-pick
branch
from
e6f2325 to
5a13374
Compare
Co-authored-by: morgangibbs87 <[email protected]>
…evert on invalid timestamps (#605) On `main`, the `Beacon.parentBlockRoot(uint256 timestamp)` function returns zero bytes if the timestamp given is invalid. This allows the `Steel.validateCommitment` to return true if given a commitment suchas `Commitment { id: Encoding.encodeVersionID(block.timestamp - 1, 1), bytes32(0), configID }` where the digest is zero and the timestamp is within the last ~24 hours but does not correspond to a valid block. This violates the semantics of `validateCommitment` in that this does not commitment to a block that is in the current chain. Because the digest is zero, it does not correspond to any block and there exist no known openings. As a result, this commitment will never be produced by a correct zkVM guest using Steel. As a result, leveraging this bug to compromise the soundness of a program using Steel would require a separate bug or misuse of the Steel API. As a fix for this issue, this PR checks whether the EIP-4788 contract call reverts, and reverts with `InvalidBlockTimestamp` if so. We choose this error message as this is the only case in which the EIP-4788 contract will revert when called from the `Beacon` contract. With this, this PR removes the explicit check that the timestamp is recent, as it is redundant. As a drive-by change, this PR also drops the explicit check for the block number being too old when using execution block commitments. Instead, this checks the return value of the `blockhash` opcode, which will return zeroes if the block number is too old. This should not result in any change of behavior on Ethereum. --------- Co-authored-by: Angelo Capossele <[email protected]> Co-authored-by: Wolfgang Welz <[email protected]>
#604) - **add contracts/script/verify-set-verifier.sh** - **add set verifier 0.7 to deployment.toml**
nategraf
force-pushed
the
victor/release-2.1-cherry-pick
branch
from
5a13374 to
ce54885
Compare
Merged
capossele
approved these changes
Jun 7, 2025
nategraf
changed the title
main to rlease 2.1 branch for 2.1.1 releasemain to release 2.1 branch for 2.1.1 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.