Skip to content

refactor lag test plan #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhoudongxu merged 1 commit into from
Jun 6, 2022
Merged

refactor lag test plan #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions doc/sai-ptf/config_data/config_t0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
- [rotue entries](#rotue-entries)
- [LAG configuration](#lag-configuration)
- [LAG and LAG members](#lag-and-lag-members)
- [LAG route and neighbor config](#lag-route-and-neighbor-config)
- [FDB Configuration](#fdb-configuration)
- [MAC Table](#mac-table)
## Overriew
Expand Down Expand Up @@ -102,12 +103,22 @@ VLAN interfaces route entries

### LAG and LAG members

|HostIf|VLAN ID|Ports|
|HostIf|LAG ID|Ports|
|-|-|-|
|Ethernet76-80|lag1|Port17-18|
|Ethernet84-88|lag2|Port19-20|
|Ethernet92-96|lag3|Port21-22|

### LAG route and neighbor config
Neighbors

|Name|IP|dest_mac|
|-|-|-|
|lag1_nb1-nb8| 192.168.0.11-192.168.0.18| 00:00:11:11:11:11-00:00:88:88:88:88|

Route entry

|DestIp|Next Hop |Next Hop ip|
|-|-|-|
|192.168.0.11-192.168.0.18|lag1:port17-18|192.168.0.11-192.168.0.18|

## FDB Configuration
### MAC Table
Expand Down
161 changes: 73 additions & 88 deletions doc/sai-ptf/lag_test_plan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,88 @@
# SAI Lag Test plan
- [SAI Lag Test plan](#sai-lag-test-plan)
- [Overriew](#overriew)
- [Test Environment](#test-environment)
- [Testbed](#testbed)
- [Test Configuration](#test-configuration)
- [Variations](#variations)
- [Test Configuration](#test-configuration)
- [Test Execution](#test-execution)
- [Basic function test](#basic-function-test)
- [PortChannel Loadbalanceing](#portchannel-loadbalanceing)
- [Testing Objective](#testing-objective)
- [Test Data/Packet](#test-datapacket)
- [Test Cases](#test-cases)
- [SAI API test](#sai-api-test)
- [Renove lag member](#remove-lag-member)
- [Testing Objective](#testing-objective)
- [Test Cases](#test-cases)
- [Disable Lag memeber](#disable-lag-memeber.)
- [Testing Objective](#testing-objective)
- [Test Data/Packet](#test-datapacket)
- [Test Cases](#test-case)
- [Test Data/Packet](#test-datapacket)
- [Test Group: L3 PortChannel Loadbalanceing](#test-group-l3-portchannel-loadbalanceing)
- [Testing Objective](#testing-objective)
- [Case2: Change destinstion_port](#case2-change-destinstion_port)
- [Case3: Change source_ip](#case3-change-source_ip)
- [Case4: Change destinstion_ip](#case4-change-destinstion_ip)
- [Case5: Case5: Change protocol](#case4-change-protocol)

## Overriew
# Overriew
The purpose of this test plan is to test the LAG/PortChannel function from SAI.

# Test Environment
## Testbed
Those tests will be run on the testbed structure, the components are:
* PTF - running in a server that can connect to the target DUT
* SAI server - running on a dut
## Test Configuration

For the test configuration, please refer to the file
- [VLAN_config](./config_data/vlan_config_t0.md)
- [FDB_config](./config_data/fdb_config_t0.md)
- [Route_config](./config_data/route_config_t0.md)
- [LAG_config](./config_data/LAG_config_t0.md)
# Test Configuration

For the test configuration, please refer to LAG configuration section ofthe file
- [Config_t0](./config_data/config_t0.md)

**Note. All the tests will be based on the configuration above, if any additional configuration is required, it will be specified in the Test case.**

## Variations
Cause the testbed might also encounter some issues like the host interface being down.
Before running the actual test there will need some sanity test to check the DUT status and select the active ports for testing.

**All the ports in this test plan just to illustrate the test purpose, they are not exactly the same for the actual environment.**

# Test Execution
## Basic function test

### PortChannel Loadbalanceing
#### Testing Objective
For load balancing, expecting the ports in a lag should receive the packet equally. Traffic direction: from server side to T1 side
Even after removing and disabling the port in a lag.

#### Test Data/Packet

[Sample_Packet](./config_data/LAG_config_t0.md#sample-datapacket)
- Input Packet
- Output Packet

#### Test Cases
| Goal| Steps/Cases | Expect |
|-|-|-|
| Prepare to send from port0 to Lag1.| Send packet with.| Lag1 and members have been created.|
| Packet forwards on port equally.| Send packet on port0 to the lag1 100 times .| Loadbalance on lag members.|
| Packet forwards on available ports equally.| Every time, disable egress/ingress on one lag member, then send packet | Loadbalance on lag members.|
| Packet forwards on available ports equally.| Every time, enable egress/ingress on one lag member, then send packet | Loadbalance on lag members.|
| Packet forwards on available ports equally.| Every time, remove one lag member, then send packet | Loadbalance on lag members.|



## SAI API test
### Remove Lag member
#### Testing Objective
Test verifies the LAG load balancing for scenario when LAG members are removed.


#### Test Data/Packet

[Sample_Packet](./config_data/LAG_config_t0.md#sample-datapacket)
- Input Packet
- Output Packet

#### Test Cases
| Goal | Steps/Cases | Expect |
|-|-|-|
|Remove lag2_member2 and forwarding packet from port0 to lag2|Remove lag2_member2 form Lag2 and Send packet on port0 to lag2 100 times| Port0 will receive an equal number of packets.|


### Disable Lag memeber
For lag, we can disable it from ingress or egress direction, after we disable the member of a lag, we expect traffic can be loadbalanced to other lag members.

#### Test Data/Packet
## Test Data/Packet
```Python
pkt = simple_udp_packet(eth_dst=ROUTER_MAC,
eth_src=src_mac,
ip_dst=dst_ip_addr,
ip_src=src_ip_addr,
udp_sport=udp_sport,
udp_dport=udp_dport,
ip_id=106,
ip_ttl=64)

exp_pkt = simple_udp_packet(eth_dst=dstmac,
ip_dst=dst_ip_addr,
ip_src=src_ip_addr,
udp_sport=udp_sport,
udp_dport=udp_dport,
ip_id=106,
ip_ttl=63)
```
TCP Packet
```Python
pkt = simple_tcp_packet(eth_dst=ROUTER_MAC,
eth_src=src_mac,
ip_dst=dst_ip_addr,
ip_src=src_ip_addr,
tcp_sport=tcp_sport,
tcpp_dport=tcp_dport,
ip_id=106,
ip_ttl=64)

exp_pkt = simple_udp_packet(eth_dst=dstmac,
ip_dst=dst_ip_addr,
ip_src=src_ip_addr,
tcp_sport=tcp_sport,
tcp_dport=tcp_dport,
ip_id=106,
ip_ttl=63)
```

## Test Group: L3 PortChannel Loadbalanceing
These cases will cover five scenarios: src/dst ip, src/dst port , protocol

### Case1: Change source_port
### Case2: Change destinstion_port
### Case3: Change source_ip
### Case4: Change destinstion_ip
### Case5: Change protocol


### Testing Objective
For load balancing, expecting the ports in a lag should receive the packet equally. Traffic direction: from server side to T1 side.

### Test steps: <!-- omit in toc -->
Test steps:
- 1.Set switch hash attribute as (SAI_NATIVE_HASH_FIELD_SRC_IP,
SAI_NATIVE_HASH_FIELD_DST_IP,
SAI_NATIVE_HASH_FIELD_IP_PROTOCOL,
SAI_NATIVE_HASH_FIELD_L4_DST_PORT,
SAI_NATIVE_HASH_FIELD_L4_SRC_PORT), which mean switch computes hash value using the five fields of packet.
- 2.Gerate different packets by updating source port/destination port/source ip/destination ip of packet.
- 3.Send these packetes on port0 to the lag1. Check if packet forwards on ports of lag1 equally.

[Sample_Packet](./config_data/LAG_config_t0.md#sample-datapacket)
- Input Packet
- Output Packet

#### Test Cases
| Goal | Steps/Cases | Expect |
|-|-|-|
|Packet dropped on port22| Disable egress and ingress on lag3 member2. send packet | Packet drop.|