feat: add support for borderRadius on Images#809
Draft
lessp wants to merge 4 commits intorevery-ui:masterfrom
Draft
feat: add support for borderRadius on Images#809lessp wants to merge 4 commits intorevery-ui:masterfrom
lessp wants to merge 4 commits intorevery-ui:masterfrom
Conversation
lessp
force-pushed
the
feature/rounded-images
branch
from
7cb7f3c to
f7f2575
Compare
lessp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partly working. The issue seems to be that once you've rendered an image with borderRadius other images won't show. I imagine there's something shared which gets overwritten perhaps.
Will depend on: revery-ui/reason-skia#63
addCircle: https://fiddle.skia.org/c/cd2ad60bbe5f957824e3eb5e074a97d9
addRoundRect: https://fiddle.skia.org/c/757d1efd0a50992e99afc135021e7cd1