Skip to content

Conversation

@reugn
Copy link
Owner

@reugn reugn commented Mar 14, 2025

  • Replace NewSlidingWindowWithExtractor with NewSlidingWindowWithOpts which takes multiple configuration options.
  • Introduce a configuration option for partial results, addressing the issue where the flow blocks until the first window is elapsed even if the upstream has closed.
  • Replace return type for event type extractor from int64 to time.Time.
  • Optimize windowing process.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.57%. Comparing base (683f3f7) to head (ce68e9a).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #165   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files          12       12           
  Lines         699      707    +8     
=======================================
+ Hits          696      704    +8     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@reugn reugn merged commit 46a369d into master Mar 14, 2025
6 checks passed
@reugn reugn deleted the sliding-window-block branch March 14, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants