chore(clippy): fix nightly lints#998
Merged
Merged
Conversation
reubeno
approved these changes
Feb 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates a couple of std::time::Duration/Result idioms to satisfy newer clippy/nightly lints in brush-core, without changing runtime behavior.
Changes:
- Adjust a timing unit test to use
Duration::from_millis(1)instead offrom_micros(1000). - Simplify
OpenFile::is_dir()by usingResult::is_ok_and().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| brush-core/src/timing.rs | Updates a unit test duration constructor to align with clippy’s preferred idioms. |
| brush-core/src/openfiles.rs | Replaces map(...).unwrap_or(false) with is_ok_and(...) for clearer Result handling. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
f59a90a to
6384a63
Compare
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
Owner
|
Thanks for proactively contributing this! The only check failure is unrelated to your change; it's something we're tracking as an upstream issue caused by recent runner changes. We won't worry about that. |
reubeno
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.