fix(complete): complete current and parent directories.#887
Conversation
f767818 to
d99396f
Compare
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
|
Thanks for posting this, @MasahikoSawada! The change looks reasonable and even seems to increase the pass rate on bash-completion tests 😄 The test failure looks like it's coming from the new assertions you've added to |
|
Hi @MasahikoSawada -- are you still interested in finishing this up? We appreciate the contribution and it would be great to get this merged. (I'm assuming it primarily needs a rebase and a look at the failing unit tests?) |
|
Hi @MasahikoSawada -- I see that you've provided access for maintainers to push to your PR branch. I've picked this back up and have a targeted adjustment to get the tests passing (and rebase against latest changes). Thanks for getting the ball rolling 😄 |
d99396f to
1f6b910
Compare
1f6b910 to
9231775
Compare
Corrects completion of `.` and `..`. --------- Co-authored-by: reuben olinsky <reubeno@users.noreply.github.com>
This PR is to complete '.' (current directory) and '..' (parent directory) correctly.