Skip to content

fix(builtins): suppress error when type -p sees no command#745

Merged
reubeno merged 1 commit into
mainfrom
type-dash-p-not-found
Nov 8, 2025
Merged

fix(builtins): suppress error when type -p sees no command#745
reubeno merged 1 commit into
mainfrom
type-dash-p-not-found

Conversation

@reubeno
Copy link
Copy Markdown
Owner

@reubeno reubeno commented Nov 8, 2025

While not described in #743, it's the next issue that neofetch seems to run into after getting the fix in #744.

Addresses inconsistency in whether type -p should emit anything to stdout or stderr when it can't find the specified command.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 8, 2025

Test Results

    3 files     23 suites   6m 51s ⏱️
1 113 tests 1 113 ✅ 0 💤 0 ❌
3 319 runs  3 319 ✅ 0 💤 0 ❌

Results for commit e198b74.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 8, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 17.51 μs 17.27 μs -0.24 μs 🟢 -1.38%
eval_arithmetic 0.15 μs 0.15 μs -0.00 μs ⚪ Unchanged
expand_one_string 1.97 μs 2.06 μs 0.09 μs ⚪ Unchanged
for_loop 22.00 μs 22.75 μs 0.75 μs 🟠 +3.42%
function_call 2.52 μs 3.14 μs 0.62 μs 🟠 +24.69%
instantiate_shell 58.13 μs 59.17 μs 1.03 μs 🟠 +1.78%
instantiate_shell_with_init_scripts 24419.63 μs 24753.44 μs 333.81 μs ⚪ Unchanged
parse_bash_completion 2049.86 μs 2044.17 μs -5.68 μs ⚪ Unchanged
parse_sample_script 1.96 μs 2.01 μs 0.05 μs 🟠 +2.40%
run_echo_builtin_command 15.46 μs 16.29 μs 0.82 μs ⚪ Unchanged
run_one_external_command 2391.96 μs 2415.24 μs 23.28 μs ⚪ Unchanged
tokenize_sample_script 3.51 μs 3.52 μs 0.02 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 73.65% 🟢 73.65% ⚪ 0%

Minimum allowed coverage is 70%, this run produced 73.65%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1348 63.92
❗️ Error 214 10.15
❌ Fail 178 8.44
⏩ Skip 354 16.79
❎ Expected Fail 14 0.66
✔️ Unexpected Pass 1 0.05
📊 Total 2109 100.00

@reubeno reubeno merged commit 5d88aa8 into main Nov 8, 2025
42 checks passed
@reubeno reubeno deleted the type-dash-p-not-found branch November 8, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant