Skip to content

test: add not-yet-passing tests for set -u and set -e#736

Merged
reubeno merged 1 commit into
mainfrom
more-tests
Nov 6, 2025
Merged

test: add not-yet-passing tests for set -u and set -e#736
reubeno merged 1 commit into
mainfrom
more-tests

Conversation

@reubeno
Copy link
Copy Markdown
Owner

@reubeno reubeno commented Nov 6, 2025

Fill out more tests for set options. Mark ones not yet passing as known failures.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 6, 2025

Test Results

    3 files     23 suites   6m 9s ⏱️
1 080 tests 1 080 ✅ 0 💤 0 ❌
3 220 runs  3 220 ✅ 0 💤 0 ❌

Results for commit 1b7289c.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 6, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 17.67 μs 17.74 μs 0.06 μs 🟠 +0.36%
eval_arithmetic 0.15 μs 0.15 μs 0.00 μs ⚪ Unchanged
expand_one_string 2.00 μs 1.98 μs -0.02 μs ⚪ Unchanged
for_loop 22.45 μs 22.13 μs -0.32 μs 🟢 -1.44%
function_call 2.58 μs 2.60 μs 0.02 μs ⚪ Unchanged
instantiate_shell 58.68 μs 58.94 μs 0.26 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 23991.30 μs 24187.90 μs 196.60 μs ⚪ Unchanged
parse_bash_completion 2034.24 μs 2056.23 μs 21.99 μs 🟠 +1.08%
parse_sample_script 1.93 μs 1.91 μs -0.02 μs 🟢 -1.14%
run_echo_builtin_command 15.78 μs 15.97 μs 0.19 μs ⚪ Unchanged
run_one_external_command 2503.46 μs 5792.45 μs 3288.99 μs 🟠 +131.38%
tokenize_sample_script 3.53 μs 3.54 μs 0.01 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-builtins/src/export.rs 🟠 71.95% 🟠 73.17% 🟢 1.22%
brush-core/src/extendedtests.rs 🟠 68.45% 🟠 68.7% 🟢 0.25%
brush-core/src/jobs.rs 🔴 37.16% 🔴 47.71% 🟢 10.55%
brush-core/src/tests.rs 🟠 57.89% 🟠 68.42% 🟢 10.53%
brush-core/src/variables.rs 🟢 88.69% 🟢 88.87% 🟢 0.18%
brush-parser/src/ast.rs 🔴 31.66% 🔴 34.7% 🟢 3.04%
brush-parser/src/test_command.rs 🔴 33.33% 🔴 40.58% 🟢 7.25%
Overall Coverage 🟢 72.94% 🟢 73.27% 🟢 0.33%

Minimum allowed coverage is 70%, this run produced 73.27%

Test Summary: bash-completion test suite

Outcome Count Percentage
✅ Pass 1345 63.77
❗️ Error 215 10.19
❌ Fail 180 8.53
⏩ Skip 354 16.79
❎ Expected Fail 14 0.66
✔️ Unexpected Pass 1 0.05
📊 Total 2109 100.00

@reubeno reubeno changed the title test: add more tests test: add not-yet-passing tests for set -u and set -e Nov 6, 2025
@reubeno reubeno merged commit b1132c7 into main Nov 6, 2025
42 checks passed
@reubeno reubeno deleted the more-tests branch November 6, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant