Conversation
Co-authored-by: Igor <ig_@tutamail.com>
Test Results 3 files 14 suites 3m 44s ⏱️ Results for commit d6ffb8e. |
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is Test Summary: bash-completion test suite
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This integrates the compat tests, clap annotation updates, and some of the core builtin updates from #219.
There are 2 notable differences with this PR's approach:
In place of a custom implementation of path normalization, this PR instead opts for adopting the
normalize-pathcrate with the acknowledged trade-off that this latter crate likely does not necessarily handle Windows paths.This version does not persistently maintain a logical and physical representation of the current working dir. Rather, it maintains the existing single representation, and only computes physical paths on-demand when required. We still may very well need to go with maintaining both, but for now this keeps the change more minimal and seems to be more in line with handling the edge case of how, for example,
pwd -Pshould behave on a directory that has been renamed/moved/altered since beingcd'd into.We will leave the older PR open for now, and re-evaluate how best to preserve/use its Windows-specific logic in subsequent changes.
(Note: @39555 -- the commit tags you as a contributor because you had done the heavy lifting of identifying the work needed and also because this PR directly incorporates some of your changes from the above-linked PR.)
Resolves: #202.