fix(exit): correct exit semantics in various compund statements#347
Merged
Conversation
31289e8 to
62f8295
Compare
Performance Benchmark Report
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Test Results 3 files 14 suites 5m 1s ⏱️ Results for commit 62f8295. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were a handful of cases where
exitwas not being honored; this attempts to resolve the lot of them, as well as add a handful of test cases to confirm the behavior matches that ofbash.Notably, we need to ignore exit-shell requests from subshells, but need to honor them when coming from within the same shell.
(Note: the way in which we have separate representations for command spawn results, execution results, and builtin execution results... leaves room for improvement. The present goal is to reach correct behavior and then we should, in time, strive to simplify the logic.)
Resolves #337