Skip to content

feat: default to reedline and add syntax highlighting support#187

Merged
reubeno merged 1 commit into
mainfrom
highlighting
Oct 4, 2024
Merged

feat: default to reedline and add syntax highlighting support#187
reubeno merged 1 commit into
mainfrom
highlighting

Conversation

@reubeno
Copy link
Copy Markdown
Owner

@reubeno reubeno commented Oct 4, 2024

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.35 μs 3.35 μs 0.00 μs ⚪ Unchanged
instantiate_shell 59.47 μs 62.07 μs 2.60 μs 🟠 +4.37%
instantiate_shell_with_init_scripts 25360.71 μs 25424.77 μs 64.06 μs ⚪ Unchanged
parse_bash_completion 2721.66 μs 2691.48 μs -30.19 μs 🟢 -1.11%
parse_sample_script 3.96 μs 3.98 μs 0.01 μs ⚪ Unchanged
run_echo_builtin_command 91.02 μs 90.50 μs -0.52 μs ⚪ Unchanged
run_one_builtin_command 111.39 μs 110.76 μs -0.63 μs ⚪ Unchanged
run_one_external_command 1989.23 μs 1981.33 μs -7.90 μs ⚪ Unchanged
run_one_external_command_directly 947.97 μs 946.39 μs -1.58 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/jobs.rs 🔴 42.42% 🔴 37.23% 🔴 -5.19%
brush-core/src/shell.rs 🟢 77% 🟢 76.28% 🔴 -0.72%
brush-interactive/src/reedline/reedline_shell.rs 🔴 0% 🟢 89.84% 🟢 89.84%
brush-interactive/src/reedline/refs.rs 🔴 0% 🟢 100% 🟢 100%
brush-interactive/src/rustyline/rustyline_shell.rs 🔴 30.53% 🔴 0% 🔴 -30.53%
Overall Coverage 🟢 72.97% 🟢 72.34% 🔴 -0.63%

Minimum allowed coverage is 70%, this run produced 72.34%

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 4, 2024

Test Results

  2 files    8 suites   50s ⏱️
422 tests 422 ✅ 0 💤 0 ❌
844 runs  844 ✅ 0 💤 0 ❌

Results for commit 8a6274a.

@reubeno reubeno merged commit e3c8320 into main Oct 4, 2024
@reubeno reubeno deleted the highlighting branch October 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant