Skip to content

fix: address multiple issues with foreground controls for pipeline commands#180

Merged
reubeno merged 1 commit into
mainfrom
fix-interactive-pipe-test
Sep 30, 2024
Merged

fix: address multiple issues with foreground controls for pipeline commands#180
reubeno merged 1 commit into
mainfrom
fix-interactive-pipe-test

Conversation

@reubeno
Copy link
Copy Markdown
Owner

@reubeno reubeno commented Sep 30, 2024

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 30, 2024

Test Results

  2 files    8 suites   1m 5s ⏱️
424 tests 424 ✅ 0 💤 0 ❌
848 runs  848 ✅ 0 💤 0 ❌

Results for commit 23282a3.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 30, 2024

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
expand_one_string 3.36 μs 3.36 μs -0.00 μs ⚪ Unchanged
instantiate_shell 60.43 μs 60.26 μs -0.17 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 25208.21 μs 25506.81 μs 298.60 μs ⚪ Unchanged
parse_bash_completion 5725.14 μs 5719.23 μs -5.91 μs ⚪ Unchanged
parse_sample_script 8.96 μs 9.00 μs 0.04 μs ⚪ Unchanged
run_echo_builtin_command 92.42 μs 92.14 μs -0.28 μs ⚪ Unchanged
run_one_builtin_command 112.37 μs 113.41 μs 1.04 μs ⚪ Unchanged
run_one_external_command 1826.22 μs 1882.34 μs 56.12 μs 🟠 +3.07%
run_one_external_command_directly 969.75 μs 958.35 μs -11.40 μs ⚪ Unchanged

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
brush-core/src/commands.rs 🟢 91% 🟢 90.2% 🔴 -0.8%
brush-core/src/interp.rs 🟢 89.66% 🟢 89.76% 🟢 0.1%
brush-core/src/sys/unix/signal.rs 🟠 63.64% 🟠 68.48% 🟢 4.84%
brush-core/src/sys/unix/terminal.rs 🔴 36.07% 🔴 37.74% 🟢 1.67%
Overall Coverage 🟢 76.14% 🟢 76.2% 🟢 0.06%

Minimum allowed coverage is 70%, this run produced 76.2%

@reubeno reubeno force-pushed the fix-interactive-pipe-test branch from 5620fa0 to 23282a3 Compare September 30, 2024 09:17
@reubeno reubeno changed the title fix: wait to regain term control until whole pipeline is done fix: address multiple issues with foreground controls for pipeline commands Sep 30, 2024
@reubeno reubeno merged commit 2ddbf61 into main Sep 30, 2024
@reubeno reubeno deleted the fix-interactive-pipe-test branch September 30, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant