Skip to content

feat: get building on windows and wasm-wasip1 targets#116

Merged
reubeno merged 1 commit into
mainfrom
win3
Jul 4, 2024
Merged

feat: get building on windows and wasm-wasip1 targets#116
reubeno merged 1 commit into
mainfrom
win3

Conversation

@reubeno

@reubeno reubeno commented Jul 4, 2024

Copy link
Copy Markdown
Owner

Adopt a more maintainable pattern for platform-specific code, and use this pattern to get minimally building for Windows x86_64 as well as wasm/WASI 0.1.

@github-actions

github-actions Bot commented Jul 4, 2024

Copy link
Copy Markdown

Test Results

403 tests   388 ✅  25s ⏱️
 64 suites   15 💤
  8 files      0 ❌

Results for commit f9dd01f.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 4, 2024

Copy link
Copy Markdown

Performance Benchmark Report

Benchmark name Baseline (ns) Test/PR (ns) Delta (ns) Delta %
expand_one_string 3604 ns 3603 ns -1 ns 🟢 -0.03%
instantiate_shell 61386 ns 61769 ns +383 ns 🟠 +0.62%
instantiate_shell_with_init_scripts 27444855 ns 27599274 ns +154419 ns 🟠 +0.56%
parse_bash_completion 5566268 ns 5574997 ns +8729 ns 🟠 +0.16%
parse_sample_script 8919 ns 8919 ns 0 ns ⚪ 0.00%
run_echo_builtin_command 94159 ns 94626 ns +467 ns 🟠 +0.50%
run_one_builtin_command 112218 ns 112331 ns +113 ns 🟠 +0.10%
run_one_external_command 1957872 ns 1920222 ns -37650 ns 🟢 -1.92%
run_one_external_command_directly 1012138 ns 1000366 ns -11772 ns 🟢 -1.16%

Code Coverage Report

Package Base Coverage New Coverage Difference
/home/runner/work/brush/brush/brush-core/src/arithmetic.rs 🟢 98.6% 🟢 98.6% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtin.rs 🔴 31.21% 🔴 31.21% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/alias.rs 🟢 83.87% 🟢 83.87% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/bg.rs 🔴 0% 🔴 0% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/break_.rs 🟢 90% 🟢 90% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/builtin_.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/cd.rs 🟢 88.57% 🟢 88.57% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/colon.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/command.rs 🟢 93.26% 🟢 93.26% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/complete.rs 🔴 21.48% 🔴 21.48% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/continue_.rs 🟢 90% 🟢 90% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/declare.rs 🟢 82.83% 🟢 82.83% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/dirs.rs 🟢 90.48% 🟢 90.48% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/dot.rs 🟢 95.65% 🟢 95.65% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/echo.rs 🟢 86.84% 🟢 86.84% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/enable.rs 🟢 91.07% 🟢 91.07% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/eval.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/exec.rs 🟢 90.32% 🟢 90.32% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/exit.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/export.rs 🟢 88.73% 🟢 88.73% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/false_.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/fg.rs 🔴 0% 🔴 0% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/getopts.rs 🟢 97.7% 🟢 97.7% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/help.rs 🟢 90.7% 🟢 90.7% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/jobs.rs 🔴 41.86% 🔴 41.86% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/kill.rs 🔴 0% 🔴 0% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/let_.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/mod.rs 🟢 94.61% 🟢 94.63% 🟢 0.02%
/home/runner/work/brush/brush/brush-core/src/builtins/popd.rs 🟢 94.12% 🟢 94.12% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/printf.rs 🟢 91.18% 🟢 91.18% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/pushd.rs 🟢 91.3% 🟢 91.3% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/pwd.rs 🟢 89.47% 🟢 89.47% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/read.rs 🟠 73.53% 🟢 76.69% 🟢 3.16%
/home/runner/work/brush/brush/brush-core/src/builtins/return_.rs 🟢 83.33% 🟢 83.33% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/set.rs 🟢 76.64% 🟢 76.64% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/shift.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/shopt.rs 🟢 88.39% 🟢 88.39% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/test.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/trap.rs 🟢 83.15% 🟢 82.95% 🔴 -0.2%
/home/runner/work/brush/brush/brush-core/src/builtins/true_.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/type_.rs 🟢 90.27% 🟢 90.27% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/umask.rs 🔴 0% 🔴 0% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/unalias.rs 🔴 0% 🔴 0% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/unimp.rs 🔴 0% 🔴 0% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/unset.rs 🟢 94.64% 🟢 94.64% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/builtins/wait.rs 🟢 85.71% 🟢 85.71% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/commands.rs 🟢 92.86% 🟢 92.82% 🔴 -0.04%
/home/runner/work/brush/brush/brush-core/src/completion.rs 🔴 42.49% 🔴 42.49% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/env.rs 🟢 87.85% 🟢 87.85% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/error.rs 🔴 25% 🔴 25% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/escape.rs 🔴 14.91% 🔴 14.91% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/expansion.rs 🟢 95.95% 🟢 95.95% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/extendedtests.rs 🟠 64.15% 🟠 69.2% 🟢 5.05%
/home/runner/work/brush/brush/brush-core/src/functions.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/interp.rs 🟢 93.17% 🟢 93.15% 🔴 -0.02%
/home/runner/work/brush/brush/brush-core/src/jobs.rs 🔴 39.38% 🔴 43.48% 🟢 4.1%
/home/runner/work/brush/brush/brush-core/src/keywords.rs 🟢 96.88% 🟢 96.88% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/namedoptions.rs 🟠 51.92% 🟠 51.92% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/openfiles.rs 🔴 46.15% 🔴 47.22% 🟢 1.07%
/home/runner/work/brush/brush/brush-core/src/options.rs 🟢 79.17% 🟢 79.17% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/patterns.rs 🟢 96.96% 🟢 96.96% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/prompt.rs 🟢 78.48% 🟢 78.48% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/regex.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/shell.rs 🟢 77.62% 🟢 77.14% 🔴 -0.48%
/home/runner/work/brush/brush/brush-core/src/sys/hostname.rs 🔴 0% 🟢 100% 🟢 100%
/home/runner/work/brush/brush/brush-core/src/sys/tokio_process.rs 🔴 0% 🟢 100% 🟢 100%
/home/runner/work/brush/brush/brush-core/src/sys/unix/fs.rs 🔴 0% 🟠 54.76% 🟢 54.76%
/home/runner/work/brush/brush/brush-core/src/sys/unix/network.rs 🔴 0% 🟢 100% 🟢 100%
/home/runner/work/brush/brush/brush-core/src/sys/unix/signal.rs 🔴 0% 🔴 40% 🟢 40%
/home/runner/work/brush/brush/brush-core/src/sys/unix/terminal.rs 🔴 0% 🔴 0% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/sys/unix/users.rs 🔴 0% 🔴 16.13% 🟢 16.13%
/home/runner/work/brush/brush/brush-core/src/tests.rs 🟠 50% 🟠 50% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/traps.rs 🟠 50% 🟠 50% ⚪ 0%
/home/runner/work/brush/brush/brush-core/src/variables.rs 🟢 79.91% 🟢 79.91% ⚪ 0%
/home/runner/work/brush/brush/brush-interactive/src/interactive_shell.rs 🟢 77.78% 🟢 78.11% 🟢 0.33%
/home/runner/work/brush/brush/brush-parser/src/arithmetic.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/ast.rs 🔴 24.91% 🔴 24.91% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/error.rs 🟢 76.92% 🟢 76.92% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/parser.rs 🟢 99.6% 🟢 99.6% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/pattern.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/prompt.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/test_command.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/tokenizer.rs 🟢 96.01% 🟢 96.01% ⚪ 0%
/home/runner/work/brush/brush/brush-parser/src/word.rs 🟢 100% 🟢 100% ⚪ 0%
/home/runner/work/brush/brush/brush-shell/src/main.rs 🟠 71.24% 🟠 71.34% 🟢 0.1%
/home/runner/work/brush/brush/brush-shell/src/productinfo.rs 🟢 100% 🟢 100% ⚪ 0%
Overall Coverage 🟢 77.91% 🟢 77.92% 🟢 0.01%

Minimum allowed coverage is 0%, this run produced 77.92%

@reubeno reubeno merged commit 6d9035e into main Jul 4, 2024
@reubeno reubeno deleted the win3 branch July 4, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant