ClientProxyGenerator fails with GWT 2.7-beta1

[komasoftware]

Hi

GWT 2.7-beta1 was just released see https://groups.google.com/forum/#!topic/google-web-toolkit-contributors/vCELYDM2_tE

I am trying to build my project but I cannot generate the client side proxies :

java.lang.NoSuchMethodException: com.google.gwt.user.rebind.rpc.SerializableTypeOracleBuilder.<init>(com.google.gwt.core.ext.TreeLogger, com.google.gwt.core.ext.PropertyOracle, com.google.gwt.core.ext.typeinfo.TypeOracle)
at java.lang.Class.getConstructor0(Class.java:2892)
at java.lang.Class.getDeclaredConstructor(Class.java:2058)
at org.restlet.rebind.ClientProxyGenerator.getSerializableTypeOracleBuilder2_2(ClientProxyGenerator.java:772)
at org.restlet.rebind.ClientProxyGenerator.generateSerializers(ClientProxyGenerator.java:572)
at org.restlet.rebind.ClientProxyGenerator.generateProxy(ClientProxyGenerator.java:500)
at org.restlet.rebind.ClientProxyGenerator.generate(ClientProxyGenerator.java:242)
at com.google.gwt.core.ext.IncrementalGenerator.generateNonIncrementally(IncrementalGenerator.java:40)

[komasoftware]

Anything I can do to help this speed up ?
GWT 2.7 RC1 has been released by now and GWT 2.7 brings tremendous advantages like fast, incremental compilation.

[jlouvel]

Thans Koen for bringing this to our attention. We are planning to release RF2.3.0 on 11/14, so it seems tight for an upgrade to GWT 2.7 RC1, but not impossible with your help!

Do you think you could manage to prepare a contribution/pull request with this upgrade, with our support?

[jlouvel]

I'm setting this to 2.3 RC1 milestone next week to see if we can take care of this, otherwise it will come up in a patch 2.3.xx version

[komasoftware]

I'd definitely want to try...
where can I find good instructions on how to setup my development environment for recompiling the GWT module then I can look into it. I'll come back with questions here and/or seek for help on the gwt mailing list...

[jlouvel]

Great! Here are some instructions to setup the build (Ant based) and develop in Eclipse (easiest path for now):
https://github.com/restlet/restlet-framework-java/wiki/Building-the-source
https://github.com/restlet/restlet-framework-java/wiki/Contribute-using-Eclipse-IDE

The key point to understand for the GWT edition maintenance is that the main Ant build is a macro build that first generates the code base for each edition (including GWT, GAE, Android, etc.) into specific directories such as "/build/editions/gwt/" In this directory you'll find a complete set of modules and libraries that you can directly import in Eclipse.

Then, once your changes to the GWT code are working (be careful of not erasing them by regenerating the editions in the main build), you can retrofit them in the main code base, using special generation directives. We can help here.

[komasoftware]

Hi

I managed to build from source. Now I am looking into the GWT dependencies.
In the libraries folder ~/restlet-framework-java/libraries, I see some GWT related dependencies :

• com.google.gwt_2.2
• com.google.gwt.server_2.3
• com.google.protobuf_2.5 (not sure if this one is here for GWT)

Why is this not simply a dependency on the GWT SDK but split up into client and server ? And I hope there is no good reason to have different versions here (gwt 2.2 vs gwt.server 2.3)...
In the build/gwt folder I can find references in different places to these dependencies in different property files.

In folder ~/restlet-framework-java/build/editions/gwt/modules I have 3 folders :

• org.restlet
• org.restlet.ext.json
• org.restlet.ext.xml
  and they each contain an Eclipse project file.

Now ... what is a 'clean' way to upgrade the dependencies on GWT :

• option 1 : before generating (add new files to library and re-generate but build will break)
• option 2 : after generating by changing the classpath in the Eclipse project (and somehow backporting the changes to the generation model?)

thx
Koen

[komasoftware]

One step at a time.
Managed to setup the GWT projects and found the critical code snippet ...

        try {
            try {
                this.stob = getSerializableTypeOracleBuilder2_5();
            } catch (Exception e2_5) {
                try {
                    this.stob = getSerializableTypeOracleBuilder2_3();
                } catch (Exception e2_3) {
                    try {
                        this.stob = getSerializableTypeOracleBuilder2_2();
                    } catch (Exception e2_2) {
                        getLogger().log(TreeLogger.ERROR, "", e2_2);
                        throw new UnableToCompleteException();
                    }
                }
            }

[jlouvel]

Definitely option 2 is better because you can experiment more quickly in Eclipse and once you have something settled, you can backport it and regenerate to confirm, and iterate again.

Regarding the dependencies, I think protobuff library is unrelated, pulled by the SDC extension AFAIR.
No reason why GWT client and service libraries are not in v2.3 together, so you should upgrade both of them to 2.7 if possible.

Let me know if you manage to fix it.

[komasoftware]

Hi Jerome,

Everything seems to work, the changes were trivial. I ended up with modifications in two files. I did not manage to package the jars. ant package in the path of the gwt edition did not seem to do anything and I was wary of loosing my changes so I made my project dependent on the Restlet GWT projects for testing.
How do we proceed from here ?
thx,
Koen

[jlouvel]

Hi Koen, very glad you were able to fix this!
The easiest for us would be to get a pull request of the master GitHub branch. Do you think your changes are backward compatible with previous GWT versions?

[komasoftware]

I have a hard time figuring out how to patch this on the main source ...

Before generating the sources, this is what I find in file ./modules/org.restlet/src/org/restlet/rebind/ClientProxyGenerator.java.gwt :

    protected void generateSerializers() throws UnableToCompleteException {
        try {
            try {
                this.stob = getSerializableTypeOracleBuilder2_3();
            } catch (Exception e2_3) {
                try {
                    this.stob = getSerializableTypeOracleBuilder2_2();
                } catch (Exception e2_2) {
                    getLogger().log(TreeLogger.ERROR, "", e2_2);
                    throw new UnableToCompleteException();
                }
            }

After generating the code, this what I find in file ./build/editions/gwt/modules/org.restlet/src/org/restlet/rebind/ClientProxyGenerator.java

    protected void generateSerializers() throws UnableToCompleteException {
        try {
            try {
              this.stob = getSerializableTypeOracleBuilder2_5();
            } catch (Exception e2_5) {
                    try {
                        this.stob = getSerializableTypeOracleBuilder2_3();
                    } catch (Exception e2_3) {
                        try {
                            this.stob = getSerializableTypeOracleBuilder2_2();
                        } catch (Exception e2_2) {
                            getLogger().log(TreeLogger.ERROR, "", e2_2);
                            throw new UnableToCompleteException();
                        }
                    }
            }

I don't understand how this can be different.

This is also where I need to insert my changes so there will be a call to getSerializableTypeOracleBuilder2_7()

Can you help me here ?

As you can see from the code, this will still work for older GWT version.

Koen