Update tracing feature example to use WildFly 28.#122
Conversation
|
@jamezp Whiling I'm writing the blog post for Tracing feature usage in WildFly, I need to upgrade this example to refer to it in the blog post. |
|
I need to think about this @liweinan. If we do this, that means this example doesn't work with WildFly 27. Maybe that's not a bad thing, but it's something to consider. |
liweinan
force-pushed
the
upgrade_tracing_example
branch
from
ecefacc to
954bc6a
Compare
|
@jamezp This PR is ready for review, could you please help to review it again when you have time? Thanks! |
liweinan
force-pushed
the
upgrade_tracing_example
branch
from
2fa7ba6 to
47cf1bb
Compare
| <dependency> | ||
| <groupId>org.jboss.resteasy</groupId> | ||
| <artifactId>resteasy-tracing-api</artifactId> | ||
| <version>${version.org.jboss.resteasy.extensions}</version> |
There was a problem hiding this comment.
This needs a <scope>runtime</scope> I think.
| <version.org.junit>5.9.2</version.org.junit> | ||
| <version.org.wildfly.arquillian>5.0.0.Alpha6</version.org.wildfly.arquillian> | ||
| <version.wildfly-maven-plugin>4.1.0.Beta5</version.wildfly-maven-plugin> | ||
| <!-- <version.wildfly-maven-plugin>4.1.0.Beta5</version.wildfly-maven-plugin>--> |
There was a problem hiding this comment.
@jamezp If I use 4.1.0.Beta5 of wildfly-maven-plugin I got this error:
[ERROR] Failed to execute goal org.wildfly.plugins:wildfly-maven-plugin:4.1.0.Beta5:run (default-cli) on project tracing-example: The server failed to start: Cannot invoke "java.io.File.toPath()" because "this.targetDir" is null -> [Help 1]I guess this is a bug in 4.1.0.Beta5.
There was a problem hiding this comment.
There must be. We shouldn't block this because of that though. I'll look at the bug. It should work though with wildfly:dev.
There was a problem hiding this comment.
| <id>wildfly27</id> | ||
| <properties> | ||
| <version.org.wildfly>27.0.1.Final</version.org.wildfly> | ||
| <dep.tracing.scope>compile</dep.tracing.scope> |
There was a problem hiding this comment.
@jamezp I have to use compile scope instead of runtime for wildfly27 or the project won't compile.
liweinan
force-pushed
the
upgrade_tracing_example
branch
from
5ce7539 to
8d46a3f
Compare
|
@jamezp All the changes are done! :D |
| <version.org.wildfly>27.0.1.Final</version.org.wildfly> | ||
| <version.org.wildfly.arquillian>5.0.0.Alpha6</version.org.wildfly.arquillian> | ||
|
|
||
| <!-- There is bug in the plugin that prevent from `mvn wildfly:run` currently, please use the command `mvn wildfly:dev` instead. --> |
There was a problem hiding this comment.
I think we can leave this off as we'll probably forget to remove it :)
add different profiles for wildfly 27
liweinan
force-pushed
the
upgrade_tracing_example
branch
from
8d46a3f to
d34609a
Compare
jamezp
left a comment
jamezp
left a comment
There was a problem hiding this comment.
I'll merge this, but I think I'm going to follow up with a PR. Really these changes aren't needed at all because we overlay the resteasy-galleon-pack which includes tracing.
Looking forward to learn about its usage! :D |
2 participants
No description provided.