fix: optimize database queries to use find_each instead of all.each #1730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace ActiveStorage::Attachment.all.each with find_each in subdomain.rb - Replace ActiveStorage::Blob.all.each with find_each in subdomain.rb - Replace executed_api_actions.where(...).each with find_each in api_namespace.rb - Improves memory efficiency for large datasets by processing records in batches - Prevents memory exhaustion when dealing with large numbers of attachments/blobs This addresses performance issues with large dataset processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses performance issues with large dataset processing.