Update Redis.php #35
Merged
Update Redis.php #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added urlencoding and base64encoding for redis password
danhunsaker
requested changes
Apr 15, 2020
Member
danhunsaker
left a comment
danhunsaker
left a comment
There was a problem hiding this comment.
Looks alright, with one exception noted below.
lib/Resque/Redis.php
Outdated
| parse_str($parts['query'], $options); | ||
| } | ||
|
|
||
| //check 'password-hashing' parameter and extracting password based on encoding |
Member
There was a problem hiding this comment.
This should probably be called password-encoding, since we're not actually hashing anything at this point...
Contributor
Author
There was a problem hiding this comment.
Made the changes as suggested
changed hashing to encoding as suggested
danhunsaker
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added urlencoding and base64encoding for redis password