Basic ability to show components that only differ by archetype/field name on same entity#9877
Conversation
|
Web viewer built successfully. If applicable, you should also test it:
Note: This comment is updated whenever you push a commit. |
Wumpf
force-pushed
the
andreas/tagged-component-path
branch
from
982a5af to
0ce966d
Compare
| .show_hierarchical( | ||
| ui, | ||
| list_item::LabelContent::new(short_component_name) | ||
| list_item::LabelContent::new(component_descr.syntax_highlighted(ui.style())) |
There was a problem hiding this comment.
this is new, gives it a bit of a touch and a good entry point for more re-usable improvement
grtlr
left a comment
grtlr
left a comment
There was a problem hiding this comment.
Wonder if it makes sense to add snapshot test that logs the same component multiple times to the same entity in re_time_panel already?
Unfortunately, I don't think we have snapshot tests for the selection panel yet.
Other than that, LGTM!
| /// Identifies in what context this smart channel was created, and who/what is holding its | ||
| /// receiving end. | ||
| #[derive(Clone, Debug, PartialEq, Eq, Hash, serde::Deserialize, serde::Serialize)] | ||
| #[expect(clippy::large_enum_variant)] |
There was a problem hiding this comment.
Why is this large all of a sudden? Ah, because re_uri.
There was a problem hiding this comment.
yeah looks like I tripped a treshhold. Something in there should probably be a separate alloc, but didn't want to go there right now
2 participants
Related
What
Or in more technical terms:
ComponentPathis now usesComponentDescriptorrather thanComponentNameThis makes this the first PR in the new series of tagged component PRs that has a clear visual & functionality impact on the Viewer (besides ~hidden features like the chunk browser)