Implement support for in-place drag-n-drop#7880
Merged
Conversation
teh-cmc
added
enhancement
teh-cmc
commented
Oct 23, 2024
Comment on lines
+1292
to
+1293
| // NOTE: Relying on `self` is dangerous, as this is called during a time where some internal | ||
| // fields may have been temporarily `take()`n out. Keep this a static method. |
Member
Author
There was a problem hiding this comment.
ask me how I know, i dare you
teh-cmc
commented
Oct 23, 2024
Comment on lines
+1311
to
+1312
| // Don't redirect data to the welcome screen. | ||
| .filter(|&app_id| app_id != &StoreHub::welcome_screen_app_id()) |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is pretty tricky to get right (unsurprisingly) --
StoreIds andRecordingIds andSetStoreInfos are all pretty finicky constructs and a lot can go wrong when loading arbitrarily things in place. But it works pretty nicely overall!24-10-23_16.25.46.patched.mp4
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.