Fix slow receive when using native WebSocket#7875
Merged
Conversation
|
Thanks for the quick fix! It'd be nice if we include some perf check in the automated test. |
jleibs
approved these changes
Oct 24, 2024
|
@jprochazk I'm currently experimenting with multiple processes sending to one rerun --serve using the code below. Is this related to this fix or is it something different? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Tested using https://github.com/slyfox3/RerunDrawLinesPerf/tree/main adapted to not use
click:Testing script (expand)
I don't have concrete numbers, but the difference is so significant that it's easier to just show it in videos:
c63bbea:
2024-10-23.13-15-11.webm
This PR:
2024-10-23.13-14-21.webm
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.