Skip to content

Comments

rr.log_file_from_path now defaults to the active app/recording ID#7864

Merged
teh-cmc merged 1 commit intomainfrom
cmc/log_file_at
Oct 23, 2024
Merged

rr.log_file_from_path now defaults to the active app/recording ID#7864
teh-cmc merged 1 commit intomainfrom
cmc/log_file_at

Conversation

@teh-cmc
Copy link
Member

@teh-cmc teh-cmc commented Oct 22, 2024

Title. This was straightforward since the ID-override machinery was already in place.

This allows for some very neat workflows, many of which are showcased in an upcoming PR.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!
  • If have noted any breaking changes to the log API in CHANGELOG.md and the migration guide

To run all checks from main, comment on the PR with @rerun-bot full-check.

@teh-cmc teh-cmc added include in changelog 🔩 data model Sorbet 🪵 Log & send APIs Affects the user-facing API for all languages labels Oct 22, 2024
@teh-cmc teh-cmc mentioned this pull request Oct 22, 2024
6 tasks
@teh-cmc teh-cmc merged commit ea91bcd into main Oct 23, 2024
@teh-cmc teh-cmc deleted the cmc/log_file_at branch October 23, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔩 data model Sorbet include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants