Skip to content

Dataframe v2: support for clear semantics #7652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teh-cmc merged 6 commits into from
Oct 10, 2024
Merged

Dataframe v2: support for clear semantics #7652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9784683
split init() into multiple methods, we'll need the breathing room
teh-cmc Oct 7, 2024
747b83e
tombstones are never part of the view contents
teh-cmc Oct 9, 2024
a3e0199
implement clear support
teh-cmc Oct 9, 2024
5bf31fd
measure clear chunks timings
teh-cmc Oct 9, 2024
4f38e23
simplify time_range computation
teh-cmc Oct 9, 2024
96dbdac
postfix for cherry pick shenanigans
teh-cmc Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions crates/store/re_chunk_store/src/dataframe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ use arrow2::{
array::ListArray as ArrowListArray,
datatypes::{DataType as ArrowDatatype, Field as ArrowField},
};
use nohash_hasher::IntSet;

use re_chunk::TimelineName;
use re_log_types::ResolvedTimeRange;
use re_log_types::{EntityPath, TimeInt, Timeline};
use re_log_types::{EntityPath, ResolvedTimeRange, TimeInt, Timeline};
use re_types_core::{ArchetypeName, ComponentName};

use crate::ChunkStore;
Expand Down Expand Up @@ -765,12 +765,22 @@ impl ChunkStore {
})
});

use re_types_core::Archetype as _;
let clear_related_components: IntSet<ComponentName> =
re_types_core::archetypes::Clear::all_components()
.iter()
.copied()
.collect();

let components = static_components
.chain(temporal_components)
.filter(|col| match col {
ColumnDescriptor::Time(_) => true,
ColumnDescriptor::Component(descr) => {
!descr.component_name.is_indicator_component()
let is_indicator = descr.component_name.is_indicator_component();
// Tombstones are not exposed to end users -- only their _effect_.
let is_tombstone = clear_related_components.contains(&descr.component_name);
!is_indicator && !is_tombstone
}
})
.collect::<BTreeSet<_>>();
Expand Down
Loading