Merged
Conversation
Member
|
Should also fix but should probably check first |
Member
Author
I checked and it's definitely not the case: |
Member
Author
|
(Although maybe the problem is not the GPU memory itself, but the reporting done by |
Member
|
Counted GPU is fed by what re_renderer holds on to, so yeah something goes sideways there. |
emilk
added a commit
that referenced
this pull request
Jul 8, 2025
### Related * Related to #10496 * Problems added in #7513 ### What When we want to free up memory, we forgot about caches for other recordings than the current one. Similarly, each frame we maintain the caches by throwing out unnecessary parts of it, but again we only did it for the currently open recording. This meant recordings that are "in the background" would still use up a lot of memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
CachesfromAppStateto theStoreHub, and make them per-recording instead of viewer-wide in the process.This is:
I'm not a fan of the implementation: it's brittle, confusing, and I don't like it. Still, it's a net improvement over the status quo, and fixes a very annoying "leak" for end users.
Before:
24-09-25_17.29.57.patched.mp4
After:
24-09-25_17.29.08.patched.mp4
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.