Conversation
emilk
added
📺 re_viewer
Deployed docs
|
emilk
force-pushed
the
emilk/new-depth-image
branch
from
22263df to
35cf95c
Compare
Member
Author
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9972316100 |
emilk
commented
Jul 17, 2024
| /// The width and height of a 2D image. | ||
| struct Resolution2D ( | ||
| "attr.python.aliases": "npt.NDArray[np.int], Sequence[int], Tuple[int, int]", | ||
| "attr.python.array_aliases": "npt.NDArray[np.int], Sequence[int]", |
Member
Author
There was a problem hiding this comment.
Should include Sequence[aliases], but maybe codegen does this?
emilk
commented
Jul 17, 2024
Wumpf
approved these changes
Jul 17, 2024
| /// | ||
| /// Return `None` if out-of-bounds. | ||
| #[inline] | ||
| pub fn get_xyc(&self, x: u32, y: u32, channel: u32) -> Option<TensorElement> { |
Member
There was a problem hiding this comment.
naming is a bit strange, it's not xyc we're getting. Why not get_element?
Member
Author
There was a problem hiding this comment.
I just want to be explicit with the parameter order, since for tensors it is usually yxc
Member
Author
|
@rerun-bot full-check |
|
Started a full build: https://github.com/rerun-io/rerun/actions/runs/9974895221 |
6 tasks
This was referenced Jul 17, 2024
emilk
added a commit
that referenced
this pull request
Jul 18, 2024
### What * Part of #6386 * Part of #6844 * Very similar to #6915 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using examples from latest `main` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6928?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [rerun.io/viewer](https://rerun.io/viewer/pr/6928?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! * [x] If have noted any breaking changes to the log API in `CHANGELOG.md` and the migration guide - [PR Build Summary](https://build.rerun.io/pr/6928) - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html) To run all checks from `main`, comment on the PR with `@rerun-bot full-check`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This changes
DepthImagefrom a tensor to a byte-blob + resolution + data-type.It adds new code for hovering images and uploading images to GPU, both general enough to also work for color images and segmentation images. This means those PRs will be a lot smaller.
Since we still need to support color and segmentation images encoded as tensors, the code is quite complex, with duplicated paths here and there. It will all get cleaned up in later PRs.
I'm reusing a lot of stuff from tensors, like
TensorMeaning,TensorStatsTensorElement, but these will be renamed and improved before #6386 is done.TODO
depth_image_ext.cppdepth_image_ext.pyChecklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.