Skip to content

Comments

Handle static text messages in TextLogView gracefully, handle overrides#6712

Merged
teh-cmc merged 2 commits intomainfrom
andreas/text-view-overrides
Jul 2, 2024
Merged

Handle static text messages in TextLogView gracefully, handle overrides#6712
teh-cmc merged 2 commits intomainfrom
andreas/text-view-overrides

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Jul 2, 2024

What

First commit wires the TextLogView to the override system. Making this part of:

Second commit makes us handle static text without errors. Allowing non-catastrophic behavior when changing the text message:

Text run using:

import rerun as rr

rr.init("rerun_example_text_log", spawn=True)

rr.set_time_seconds("t", 0.0)
rr.log("log", rr.TextLog("Application started.", level=rr.TextLogLevel.INFO))
rr.set_time_seconds("t", 0.1)
rr.log("log", rr.TextLog("Application wumpfed.", level=rr.TextLogLevel.WARN))
rr.set_time_seconds("t", 100.0)
rr.log("log", rr.TextLog("Thing happening", color=0xFF9001FF, level=rr.TextLogLevel.ERROR))
text.editing.mp4

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself include in changelog labels Jul 2, 2024
@teh-cmc teh-cmc self-requested a review July 2, 2024 10:52
@teh-cmc teh-cmc merged commit 917f24f into main Jul 2, 2024
@teh-cmc teh-cmc deleted the andreas/text-view-overrides branch July 2, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants