Skip to content

Comments

TimeSeriesAggregation can now be set per SeriesLine (and as blueprint default per View)#6558

Merged
Wumpf merged 8 commits intomainfrom
andreas/timeseriesaggregator-component
Jun 14, 2024
Merged

TimeSeriesAggregation can now be set per SeriesLine (and as blueprint default per View)#6558
Wumpf merged 8 commits intomainfrom
andreas/timeseriesaggregator-component

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Jun 13, 2024

What

Adds TimeSeriesAggreation component to SeriesLine, allowing to set it both per line and as a component default.

example:

rr.log("trig/sin", rr.SeriesLine(color=[255, 0, 0], name="sin(0.01t)", aggregator="minmax"), static=True)

This is good step forward overall but there's problems with this PR

--

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

To run all checks from main, comment on the PR with @rerun-bot full-check.

@Wumpf Wumpf added 🍏 primitives Relating to Rerun primitives include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages feat-plots Plots, charts, graphs, timeseries, … labels Jun 13, 2024
@github-actions
Copy link

github-actions bot commented Jun 13, 2024

Deployed docs

Commit Link
64add87 https://landing-pdh15k6s7-rerun.vercel.app/docs

Wumpf added a commit that referenced this pull request Jun 13, 2024
### What

And add a colormap edit ui - this allows to use colormap in
overrides/defaults and makes it visible when logged:

Before:
<img width="302" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/1b79b6c8-e441-4cc2-87a9-fc89282a1a84">

After:
<img width="303" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/c44c720c-3b89-4eee-b2f8-468d4eb5af9b">


Discovered while working on #6558 which had the same issue.


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6559?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6559?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6559)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
@Wumpf Wumpf removed the do-not-merge Do not merge this PR label Jun 14, 2024
@Wumpf Wumpf merged commit 5e91a30 into main Jun 14, 2024
@Wumpf Wumpf deleted the andreas/timeseriesaggregator-component branch June 14, 2024 09:44
Wumpf added a commit that referenced this pull request Jun 14, 2024
…adius scaling (#6566)

### What

Introduces `FillRatio` component. Example:
```python
rr.log("world/camera/depth", rr.DepthImage(depth_image, meter=10_000.0, backproject_radius_scale=0.2))
```

* Almost done with #5067
    * This was the last legacy property to blueprintify!
* Only the actual cleanup is missing. Some of it already creeped in here
since clippy noticed the cascade of unused things, but I went only as
far as I had to to make it happy to keep this PR sane


Works as before:
<img width="1167" alt="image"
src="https://github.com/rerun-io/rerun/assets/1220815/b564944b-c4a3-459a-a9a0-9692caeb5110">

Based on #6558 to avoid conflicts


### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [ ] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6566?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6566?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6566)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat-plots Plots, charts, graphs, timeseries, … include in changelog 🪵 Log & send APIs Affects the user-facing API for all languages 🍏 primitives Relating to Rerun primitives

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zoom aggregation is always MinMax

2 participants