Skip to content

Comments

Fix layouting issue on welcome screen for narrow window, triggering debug assertion#5650

Merged
Wumpf merged 1 commit intomainfrom
andreas/layoutout-panic-fix
Mar 22, 2024
Merged

Fix layouting issue on welcome screen for narrow window, triggering debug assertion#5650
Wumpf merged 1 commit intomainfrom
andreas/layoutout-panic-fix

Conversation

@Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 22, 2024

What

This is a speculative fix, didn't have a repro. From the callstack we know that a certain ui.set_max_width(column_width - 8.0); might have gotten a too small width. Looking at how column_width is produced this may very well happen if for some reason there's very little available_width.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@Wumpf Wumpf added 📺 re_viewer affects re_viewer itself exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 22, 2024
@Wumpf
Copy link
Member Author

Wumpf commented Mar 22, 2024

correction! I got a repro!
Without this fix you can crash (on debug) the viewer by expanding the left (empty) blueprint panel such that there's no space for example columns anymore

@Wumpf Wumpf added 💣 crash crash, deadlock/freeze, do-no-start include in changelog and removed exclude from changelog PRs with this won't show up in CHANGELOG.md labels Mar 22, 2024
@Wumpf Wumpf changed the title Fix layouting debug assertion trigger on welcome screen Fix layouting issue on welcome screen for narrow window, triggering debug assertion Mar 22, 2024
@github-actions
Copy link

Size changes

Name main 5650/merge Change
rrt-star.rrd 10.46 MiB 1.80 MiB -82.79%

@Wumpf Wumpf merged commit e9e9025 into main Mar 22, 2024
@Wumpf Wumpf deleted the andreas/layoutout-panic-fix branch March 22, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💣 crash crash, deadlock/freeze, do-no-start include in changelog 📺 re_viewer affects re_viewer itself

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layout code panics

2 participants