Fix depth cloud bounding boxes for depth cloud visualizations with transforms#5578
Merged
Fix depth cloud bounding boxes for depth cloud visualizations with transforms#5578
Conversation
Wumpf
added
🪳 bug
teh-cmc
approved these changes
Mar 20, 2024
emilk
reviewed
Mar 20, 2024
| impl DepthCloud { | ||
| /// World-space bounding-box. | ||
| pub fn bbox(&self) -> macaw::BoundingBox { | ||
| pub fn world_space_bbox(&self) -> macaw::BoundingBox { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bounding box was accidentally transformed twice!
Noticed by @roym899 - bounding boxes for depth clouds are still not perfect since they take the bounding box of the full theoretical frustum and not the points displayed, but it's a lot better
Before:
After:
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io