Conversation
Wumpf
changed the title
emilk
approved these changes
Mar 17, 2024
Member
emilk
left a comment
emilk
left a comment
There was a problem hiding this comment.
Very nice! But needs to re-add that forward declaration
| return datatype; | ||
| } | ||
|
|
||
| Result<std::shared_ptr<arrow::Array>> Loggable<blueprint::components::ColumnShare>::to_arrow( |
Member
There was a problem hiding this comment.
did you change the order of the functions just to get a bigger diff ;)
Member
Author
There was a problem hiding this comment.
lol yeah I thought about avoiding that but it just happened because the last function is now optionally appended to the vec of methods on Loggable. It's annoying but 🤷
5 tasks
Wumpf
added a commit
that referenced
this pull request
Mar 18, 2024
…5557) ### What Hitting some spurious asan issues on ci: Some Linux runs end up spamming `AddressSanitizer:DEADLYSIGNAL` indefinitely with no additional information. Originally I suspected this came from * #5544 But it's actually a Github image issue, see actions/runner-images#9491 ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/5557/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/5557/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/5557/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG * [x] If applicable, add a new check to the [release checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)! - [PR Build Summary](https://build.rerun.io/pr/5557) - [Docs preview](https://rerun.io/preview/8ac1180d749f9bf9ae62ee57f96c66c832758a9d/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/8ac1180d749f9bf9ae62ee57f96c66c832758a9d/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
emilk
changed the title
.cpp files: Inline forward serialization of transparent components to their respective datatypes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fill_arrow_array_builder_methodif it's not needed@ reviewer: all the interesting changes are
crates/re_types_builder/src/codegen/cpp/mod.rs, everything else is just an exampleChecklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io