Make pinhole.hpp robust against min/max preprocessor macros (typically from windows.h)#5432
Merged
Make pinhole.hpp robust against min/max preprocessor macros (typically from windows.h)#5432
pinhole.hpp robust against min/max preprocessor macros (typically from windows.h)#5432Conversation
…dows.h) And add a test to ensure we don't run into this again!
Wumpf
added
🪳 bug
Wumpf
changed the title
abey79
approved these changes
Mar 8, 2024
| // | ||
| // This test checks that rerun.h is robust against this issue by explicitly setting `min`/`max` macros and including rerun.hpp. | ||
| #define min(a, b) (this does not compile) | ||
| #define max(a, b) (this does not compile) |
emilk
changed the title
pinhole.hpp robust against min/max preprocessor macros (typically from windows.h)
emilk
changed the title
pinhole.hpp robust against min/max preprocessor macros (typically from windows.h)pinhole.hpp robust against min/max preprocessor macros (typically from windows.h)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
And add a test to ensure we don't run into this again!
Checklist
mainbuild: app.rerun.ionightlybuild: app.rerun.io