Skip to content

Comments

Fix ugly UI for some arrow data#5235

Merged
emilk merged 5 commits intomainfrom
emilk/shorter-arrow-tooltip
Feb 20, 2024
Merged

Fix ugly UI for some arrow data#5235
emilk merged 5 commits intomainfrom
emilk/shorter-arrow-tooltip

Conversation

@emilk
Copy link
Member

@emilk emilk commented Feb 20, 2024

What

Improve the display of arbitrary arrow data, slightly.

There were several problems:

  • We were displaying huge datatypes (unions)
  • We were not respecting the max toolbar size
  • We were falling back on datatype too early

Before:
Screenshot 2024-02-20 at 10 46 21

After:
Screenshot 2024-02-20 at 10 46 02

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I have tested the web demo (if applicable):
  • The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG
  • If applicable, add a new check to the release checklist!

@emilk emilk added 🪳 bug Something isn't working ui concerns graphical user interface 📺 re_viewer affects re_viewer itself include in changelog labels Feb 20, 2024
@emilk emilk merged commit 285d1fe into main Feb 20, 2024
@emilk emilk deleted the emilk/shorter-arrow-tooltip branch February 20, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🪳 bug Something isn't working include in changelog 📺 re_viewer affects re_viewer itself ui concerns graphical user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants